From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46169)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1bIDoc-0003Y4-Jg
	for qemu-devel@nongnu.org; Wed, 29 Jun 2016 07:37:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1bIDoY-0008Lt-Qy
	for qemu-devel@nongnu.org; Wed, 29 Jun 2016 07:37:58 -0400
Received: from mx1.redhat.com ([209.132.183.28]:58116)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1bIDoY-0008Lp-Kq
	for qemu-devel@nongnu.org; Wed, 29 Jun 2016 07:37:54 -0400
Date: Wed, 29 Jun 2016 12:37:49 +0100
From: "Daniel P. Berrange" <berrange@redhat.com>
Message-ID: <20160629113749.GI4221@redhat.com>
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
References: <1465920443-22804-1-git-send-email-berrange@redhat.com>
	<1465920443-22804-6-git-send-email-berrange@redhat.com>
	<CAJ+F1CLS0Wqi9pRZAgZQSFQQKEdCxSdzKLO_dw9WcApz47XG=g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CAJ+F1CLS0Wqi9pRZAgZQSFQQKEdCxSdzKLO_dw9WcApz47XG=g@mail.gmail.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v6 5/7] util: add QAuthZ object as an
 authorization base class
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau <marcandre.lureau@gmail.com>
Cc: QEMU <qemu-devel@nongnu.org>, Markus Armbruster <armbru@redhat.com>, Max Reitz <mreitz@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Andreas =?utf-8?Q?F=C3=A4rber?= <afaerber@suse.de>

On Tue, Jun 28, 2016 at 06:22:10PM +0200, Marc-Andr=C3=A9 Lureau wrote:

> > +
> > +static const TypeInfo authz_info =3D {
> > +    .parent =3D TYPE_OBJECT,
> > +    .name =3D TYPE_QAUTHZ,
> > +    .instance_size =3D sizeof(QAuthZ),
> > +    .class_size =3D sizeof(QAuthZClass),
>=20
> .abstract =3D true? (perhaps it's not necessary, but that would be more=
 clear)

Yes, makes sense to add that since you can't instantiate this class
and do anything useful with it.


Regards,
Daniel
--=20
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange=
/ :|
|: http://libvirt.org              -o-             http://virt-manager.or=
g :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr=
/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vn=
c :|