From: David Gibson <david@gibson.dropbear.id.au>
To: Bharata B Rao <bharata@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org, thuth@redhat.com
Subject: Re: [Qemu-devel] [PATCH v0] spapr: Restore support for 970MP and POWER8NVL CPU cores
Date: Thu, 30 Jun 2016 10:46:30 +1000 [thread overview]
Message-ID: <20160630004630.GO8885@voom.fritz.box> (raw)
In-Reply-To: <1467200246-32708-1-git-send-email-bharata@linux.vnet.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 2994 bytes --]
On Wed, Jun 29, 2016 at 05:07:26PM +0530, Bharata B Rao wrote:
> Introduction of core based CPU hotplug for PowerPC sPAPR didn't
> add support for 970MP and POWER8NVL based core types. Add support for
> the same.
>
> While we are here, add support for explicit specification of POWER5+_v2.1
> core type.
>
> Signed-off-by: Bharata B Rao <bharata@linux.vnet.ibm.com>
Applied to ppc-for-2.7, thanks.
> ---
> hw/ppc/spapr_cpu_core.c | 20 ++++++++++++++++++--
> 1 file changed, 18 insertions(+), 2 deletions(-)
>
> diff --git a/hw/ppc/spapr_cpu_core.c b/hw/ppc/spapr_cpu_core.c
> index 2aa0dc5..e30b159 100644
> --- a/hw/ppc/spapr_cpu_core.c
> +++ b/hw/ppc/spapr_cpu_core.c
> @@ -337,12 +337,15 @@ static void glue(glue(spapr_cpu_core_, _fname), _initfn(Object *obj)) \
> core->cpu_class = oc; \
> }
>
> +SPAPR_CPU_CORE_INITFN(970mp_v1.0, 970MP_v10);
> +SPAPR_CPU_CORE_INITFN(970mp_v1.1, 970MP_v11);
> SPAPR_CPU_CORE_INITFN(970_v2.2, 970);
> SPAPR_CPU_CORE_INITFN(POWER5+_v2.1, POWER5plus);
> SPAPR_CPU_CORE_INITFN(POWER7_v2.3, POWER7);
> SPAPR_CPU_CORE_INITFN(POWER7+_v2.1, POWER7plus);
> SPAPR_CPU_CORE_INITFN(POWER8_v2.0, POWER8);
> SPAPR_CPU_CORE_INITFN(POWER8E_v2.1, POWER8E);
> +SPAPR_CPU_CORE_INITFN(POWER8NVL_v1.0, POWER8NVL);
>
> typedef struct SPAPRCoreInfo {
> const char *name;
> @@ -350,10 +353,19 @@ typedef struct SPAPRCoreInfo {
> } SPAPRCoreInfo;
>
> static const SPAPRCoreInfo spapr_cores[] = {
> - /* 970 */
> + /* 970 and aliaes */
> + { .name = "970_v2.2", .initfn = spapr_cpu_core_970_initfn },
> { .name = "970", .initfn = spapr_cpu_core_970_initfn },
>
> - /* POWER5 */
> + /* 970MP variants and aliases */
> + { .name = "970MP_v1.0", .initfn = spapr_cpu_core_970MP_v10_initfn },
> + { .name = "970mp_v1.0", .initfn = spapr_cpu_core_970MP_v10_initfn },
> + { .name = "970MP_v1.1", .initfn = spapr_cpu_core_970MP_v11_initfn },
> + { .name = "970mp_v1.1", .initfn = spapr_cpu_core_970MP_v11_initfn },
> + { .name = "970mp", .initfn = spapr_cpu_core_970MP_v11_initfn },
> +
> + /* POWER5 and aliases */
> + { .name = "POWER5+_v2.1", .initfn = spapr_cpu_core_POWER5plus_initfn },
> { .name = "POWER5+", .initfn = spapr_cpu_core_POWER5plus_initfn },
>
> /* POWER7 and aliases */
> @@ -373,6 +385,10 @@ static const SPAPRCoreInfo spapr_cores[] = {
> { .name = "POWER8E_v2.1", .initfn = spapr_cpu_core_POWER8E_initfn },
> { .name = "POWER8E", .initfn = spapr_cpu_core_POWER8E_initfn },
>
> + /* POWER8NVL and aliases */
> + { .name = "POWER8NVL_v1.0", .initfn = spapr_cpu_core_POWER8NVL_initfn },
> + { .name = "POWER8NVL", .initfn = spapr_cpu_core_POWER8NVL_initfn },
> +
> { .name = NULL }
> };
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2016-06-30 1:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 11:37 [Qemu-devel] [PATCH v0] spapr: Restore support for 970MP and POWER8NVL CPU cores Bharata B Rao
2016-06-29 12:28 ` Thomas Huth
2016-06-29 13:33 ` Bharata B Rao
2016-06-30 0:46 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160630004630.GO8885@voom.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=bharata@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).