From: Bharata B Rao <bharata@linux.vnet.ibm.com>
To: Greg Kurz <groug@kaod.org>
Cc: David Gibson <david@gibson.dropbear.id.au>,
Peter Crosthwaite <crosthwaite.peter@gmail.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Alexander Graf <agraf@suse.de>,
qemu-devel@nongnu.org, qemu-ppc@nongnu.org,
Cedric Le Goater <clg@kaod.org>,
Scott Wood <scottwood@freescale.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH 1/8] spapr: drop reference on child object during core realization
Date: Thu, 30 Jun 2016 09:57:58 +0530 [thread overview]
Message-ID: <20160630042758.GB21596@in.ibm.com> (raw)
In-Reply-To: <146723342014.9665.3613446436074803191.stgit@bahia.lan>
On Wed, Jun 29, 2016 at 10:50:20PM +0200, Greg Kurz wrote:
> When a core is being realized, we create a child object for each thread
> of the core.
>
> The child is first initialized with object_initialize() which sets its ref
> count to 1, and then added to the core with object_property_add_child()
> which bumps the ref count to 2.
>
> When the core gets released, object_unparent() decreases the ref count to 1,
> and we g_free() the object: we hence loose the reference on an unfinalized
> object. This is likely to cause random crashes.
>
> Let's drop the extra reference as soon as we don't need it, after the
> thread is added to the core.
>
> Signed-off-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Bharata B Rao <bharata@linux.vnet.ibm.com>
next prev parent reply other threads:[~2016-06-30 4:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 20:50 [Qemu-devel] [PATCH 0/8] ppc: compute cpu_dt_id in the machine code Greg Kurz
2016-06-29 20:50 ` [Qemu-devel] [PATCH 1/8] spapr: drop reference on child object during core realization Greg Kurz
2016-06-30 4:27 ` Bharata B Rao [this message]
2016-06-29 20:50 ` [Qemu-devel] [PATCH 2/8] spapr: do proper error propagation in spapr_cpu_core_realize_child() Greg Kurz
2016-06-30 4:28 ` Bharata B Rao
2016-06-29 20:50 ` [Qemu-devel] [PATCH 3/8] spapr: drop duplicate variable in spapr_core_release() Greg Kurz
2016-06-30 4:29 ` Bharata B Rao
2016-06-29 20:50 ` [Qemu-devel] [PATCH 4/8] exec: add missing conditional compilation Greg Kurz
2016-06-29 20:51 ` [Qemu-devel] [PATCH 5/8] exec: move cpu_index init and exit to their own function Greg Kurz
2016-06-29 20:51 ` [Qemu-devel] [PATCH 6/8] ppc: move cpu index setup to instance_init/finalize Greg Kurz
2016-06-29 20:51 ` [Qemu-devel] [PATCH 7/8] cpu: add initialization helper without realize Greg Kurz
2016-06-29 20:51 ` [Qemu-devel] [PATCH 8/8] hw/ppc: move DT cpu id generation to machine code Greg Kurz
2016-06-29 21:07 ` [Qemu-devel] [Qemu-ppc] [PATCH 0/8] ppc: compute cpu_dt_id in the " Greg Kurz
2016-06-30 5:07 ` [Qemu-devel] " David Gibson
2016-06-30 7:34 ` Igor Mammedov
2016-06-30 9:43 ` Greg Kurz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160630042758.GB21596@in.ibm.com \
--to=bharata@linux.vnet.ibm.com \
--cc=agraf@suse.de \
--cc=benh@kernel.crashing.org \
--cc=clg@kaod.org \
--cc=crosthwaite.peter@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=groug@kaod.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rth@twiddle.net \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).