From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52935) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bITbx-0002Cw-R3 for qemu-devel@nongnu.org; Thu, 30 Jun 2016 00:29:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bITbt-0001O9-RC for qemu-devel@nongnu.org; Thu, 30 Jun 2016 00:29:57 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:61039) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bITbt-0001O3-Hw for qemu-devel@nongnu.org; Thu, 30 Jun 2016 00:29:53 -0400 Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u5U4ShHX015508 for ; Thu, 30 Jun 2016 00:29:53 -0400 Received: from e28smtp08.in.ibm.com (e28smtp08.in.ibm.com [125.16.236.8]) by mx0a-001b2d01.pphosted.com with ESMTP id 23uwt8baga-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Thu, 30 Jun 2016 00:29:52 -0400 Received: from localhost by e28smtp08.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 30 Jun 2016 09:59:49 +0530 Date: Thu, 30 Jun 2016 09:59:43 +0530 From: Bharata B Rao Reply-To: bharata@linux.vnet.ibm.com References: <146723340662.9665.6413150884317978000.stgit@bahia.lan> <146723344568.9665.8138511936964587804.stgit@bahia.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <146723344568.9665.8138511936964587804.stgit@bahia.lan> Message-Id: <20160630042943.GD21596@in.ibm.com> Subject: Re: [Qemu-devel] [PATCH 3/8] spapr: drop duplicate variable in spapr_core_release() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Greg Kurz Cc: David Gibson , Peter Crosthwaite , Benjamin Herrenschmidt , Alexander Graf , qemu-devel@nongnu.org, qemu-ppc@nongnu.org, Cedric Le Goater , Scott Wood , Paolo Bonzini , Richard Henderson On Wed, Jun 29, 2016 at 10:50:45PM +0200, Greg Kurz wrote: > Signed-off-by: Greg Kurz > --- > hw/ppc/spapr_cpu_core.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/hw/ppc/spapr_cpu_core.c b/hw/ppc/spapr_cpu_core.c > index 2615058da745..a15dc010626d 100644 > --- a/hw/ppc/spapr_cpu_core.c > +++ b/hw/ppc/spapr_cpu_core.c > @@ -101,9 +101,8 @@ static void spapr_core_release(DeviceState *dev, void *opaque) > sPAPRCPUCore *sc = SPAPR_CPU_CORE(OBJECT(dev)); > const char *typename = object_class_get_name(sc->cpu_class); > size_t size = object_type_get_instance_size(typename); > sPAPRMachineState *spapr = SPAPR_MACHINE(qdev_get_machine()); > - sPAPRCPUCore *core = SPAPR_CPU_CORE(OBJECT(dev)); > CPUCore *cc = CPU_CORE(dev); > int smt = kvmppc_smt_threads(); > int i; > > @@ -119,9 +118,9 @@ static void spapr_core_release(DeviceState *dev, void *opaque) > } > > spapr->cores[cc->core_id / smt] = NULL; > > - g_free(core->threads); > + g_free(sc->threads); > object_unparent(OBJECT(dev)); > } > > void spapr_core_unplug(HotplugHandler *hotplug_dev, DeviceState *dev, Reviewed-by: Bharata B Rao