From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59471) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bIUKV-0001nF-Fw for qemu-devel@nongnu.org; Thu, 30 Jun 2016 01:16:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bIUKR-0002Xl-9Z for qemu-devel@nongnu.org; Thu, 30 Jun 2016 01:15:58 -0400 Date: Thu, 30 Jun 2016 15:07:41 +1000 From: David Gibson Message-ID: <20160630050741.GQ8885@voom.fritz.box> References: <146723340662.9665.6413150884317978000.stgit@bahia.lan> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="zywvytGCXzdVpkje" Content-Disposition: inline In-Reply-To: <146723340662.9665.6413150884317978000.stgit@bahia.lan> Subject: Re: [Qemu-devel] [PATCH 0/8] ppc: compute cpu_dt_id in the machine code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Greg Kurz Cc: Peter Crosthwaite , Benjamin Herrenschmidt , Alexander Graf , qemu-devel@nongnu.org, qemu-ppc@nongnu.org, Cedric Le Goater , bharata@linux.vnet.ibm.com, Scott Wood , Paolo Bonzini , Richard Henderson --zywvytGCXzdVpkje Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 29, 2016 at 10:50:06PM +0200, Greg Kurz wrote: > This series is a sequel to the discussion on a patch from Ben's powernv > patchset: >=20 > http://patchwork.ozlabs.org/patch/597153/ >=20 > Indeed, since the DT is a machine abstraction, it should definitely sit > under hw/ppc and not in the target code: > - all machine types are forced to share the same numbering logic > - user mode does not need that =3D> there are #ifdef everywhere >=20 > So this series moves all the current numbering logic to the machine > code. It also provides the ability for each machine type to provide > its own numbering logic instead of using the legacy one. >=20 > The current code computes cpu_dt_id out of cpu_index, both getting > their values during cpu realization. >=20 > The idea is to compute cpu_index at cpu initialization time, so > that the machine can compute cpu_dt_id before realizing the cpu. >=20 > I had to fix some issues and to do some more structural changes to have > this working, hence the RFC tag. The first 4 patches are bug fixes. The > next ones do what the subject says. >=20 > This patchset is based on David's ppc-for-2.7 branch. I could test it pla= ys > nicely with Bharata's CPU hotplug code for sPAPR. >=20 > There are some more places where the cpu_dt_id logic is open coded in the > sPAPR code. It may be worth to consolidate that in follow-up patches. Also > maybe other machine types may provide their own numbering logic if the > current one is not appropriate. Since they're clear bugfixes, I've applied 1-3/8 to ppc-for-2.7. As you say the rest of the series needs more discussion. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --zywvytGCXzdVpkje Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXdKkdAAoJEGw4ysog2bOSkB4P/2jOxDYSx6TlOECRGzqzWqi4 BWlJo/xxFr5hdXTfkIsKGZVoL67duq3MLm+QPD6+wJmZYcOi9dOxwYPYM+efBTQv SkJU58I2jjTxs6461M1z4n0f9xfeDiwBCgy7vJNvTGLLU2JlfYAu7gd/BP5D37PE isctEBBoSnRAvrjk11UihyqSezurDLxVUH8TNKgEyvtcqiHGvG6ldULOlv/DbPOn 32jus50oh1EqNz8mIPq6rQ2tyjx8je9I7LP+45pqozVpxtgdDi/tLppoMMESBals Y1CqrziyUPPYm4AJChkHkl6kVbjmnfqtDWIlnXbwClbTY/96zA+6bh47nEUnsddk SNKfEMaZFEtGgZs+SmdvcDeWSyb94ZWM6qrFqQ3llv5GyK8F7hQbb/x9yHbFPwzs kEB+2yH34P5Z5Pn52s1DuXPfvSVwpc4foRccjDBKauUUYq/5d0YSvyF9TKeGjiR7 R9dl68qbFcCDVlQYIp2SCWPsERq+QrBSbC5dS9NXBMzuwdYlArHnaugd/berLTIN MA+K2oVML7WUKjfxX+w6SKRPF1IrHqPIfnORw74cBpF/VqgPg6/Q8eu7V/BQqOsA buuk6q2FkV52uobpDIch3vIPPwajXOvHg/jLpXv76Erhj0MlzPO7TZW0RbAbriko uvvVfoT9Yj5TS4LGKsOa =wH1D -----END PGP SIGNATURE----- --zywvytGCXzdVpkje--