Re: [Qemu-devel] [PATCH] dirty-bitmap: remove unnecessary return

[Fam Zheng <famz@redhat.com>]

On Thu, 06/30 16:01, Changlong Xie wrote:
> Otherwise, we could never trigger assert(!bitmap->successor)
> 
> Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
> ---
>  block/dirty-bitmap.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/block/dirty-bitmap.c b/block/dirty-bitmap.c
> index 4902ca5..e9df5ac 100644
> --- a/block/dirty-bitmap.c
> +++ b/block/dirty-bitmap.c
> @@ -131,7 +131,6 @@ int bdrv_dirty_bitmap_create_successor(BlockDriverState *bs,
>      if (bdrv_dirty_bitmap_frozen(bitmap)) {
>          error_setg(errp, "Cannot create a successor for a bitmap that is "
>                     "currently frozen");
> -        return -1;
>      }
>      assert(!bitmap->successor);

This is wrong. Then we will always trigger assert for a frozen bitmap.

Fam