From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40662)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1bIXHs-0005Gg-1D
	for qemu-devel@nongnu.org; Thu, 30 Jun 2016 04:25:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1bIXHo-0001gU-AU
	for qemu-devel@nongnu.org; Thu, 30 Jun 2016 04:25:26 -0400
Received: from mx1.redhat.com ([209.132.183.28]:42924)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1bIXHo-0001gQ-4i
	for qemu-devel@nongnu.org; Thu, 30 Jun 2016 04:25:24 -0400
Date: Thu, 30 Jun 2016 16:25:15 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20160630082515.GG23296@ad.usersys.redhat.com>
References: <1467273706-5732-1-git-send-email-xiecl.fnst@cn.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1467273706-5732-1-git-send-email-xiecl.fnst@cn.fujitsu.com>
Subject: Re: [Qemu-devel] [PATCH] dirty-bitmap: remove unnecessary return
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
Cc: qemu devel <qemu-devel@nongnu.org>, Kevin Wolf <kwolf@redhat.com>, Jeff Cody <jcody@redhat.com>, Max Reitz <mreitz@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>

On Thu, 06/30 16:01, Changlong Xie wrote:
> Otherwise, we could never trigger assert(!bitmap->successor)
> 
> Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
> ---
>  block/dirty-bitmap.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/block/dirty-bitmap.c b/block/dirty-bitmap.c
> index 4902ca5..e9df5ac 100644
> --- a/block/dirty-bitmap.c
> +++ b/block/dirty-bitmap.c
> @@ -131,7 +131,6 @@ int bdrv_dirty_bitmap_create_successor(BlockDriverState *bs,
>      if (bdrv_dirty_bitmap_frozen(bitmap)) {
>          error_setg(errp, "Cannot create a successor for a bitmap that is "
>                     "currently frozen");
> -        return -1;
>      }
>      assert(!bitmap->successor);

This is wrong. Then we will always trigger assert for a frozen bitmap.

Fam