Re: [Qemu-devel] [PATCH v2 1/2] trace: [linux-user] Commandline arguments to control tracing

[Stefan Hajnoczi <stefanha@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1485 bytes --]

On Wed, Jun 29, 2016 at 12:45:23PM +0200, Lluís Vilanova wrote:
> Stefan Hajnoczi writes:
> 
> > On Wed, Jun 22, 2016 at 12:04:35PM +0200, Lluís Vilanova wrote:
> >> @@ -4047,6 +4064,12 @@ static const struct qemu_argument arg_table[] = {
> >> "",           "log system calls"},
> >> {"seed",       "QEMU_RAND_SEED",   true,  handle_arg_randseed,
> >> "",           "Seed for pseudo-random number generator"},
> >> +    {"trace-enable", "QEMU_TRACE_ENABLE",true,  handle_arg_trace_enable,
> >> +     "name",       "enable tracing of specified event names (pass 'help' to show a list of events)"},
> >> +    {"trace-events", "QEMU_TRACE_EVENTS",true,  handle_arg_trace_events,
> >> +     "eventsfile", "enable tracing of specified event names (one name/pattern per line)"},
> >> +    {"trace-file", "QEMU_TRACE_FILE",  true,  handle_arg_trace_file,
> >> +     "tracefile",  "output trace file"},
> 
> > Riku: These command-line options differ from the qemu-system -trace
> > option.  Should there be consistency or does *-user do its own thing?
> 
> Do you mean it differs on semantics or on syntax? For the latter, *-user option
> parsers do not use the more flexible parser used in vl.c (each has their own
> much simpler implementation).

Yes, they use different implementations.  This point where an option is
being carried over from softmmu to -user it's worth discussing again
whether it's good for the command-lines to be ad-hoc and different.

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]