From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38932) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bIbUf-0001iB-4k for qemu-devel@nongnu.org; Thu, 30 Jun 2016 08:54:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bIbUa-0007vk-To for qemu-devel@nongnu.org; Thu, 30 Jun 2016 08:54:56 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:23591) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bIbUa-0007vY-KY for qemu-devel@nongnu.org; Thu, 30 Jun 2016 08:54:52 -0400 Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u5UCrWse019864 for ; Thu, 30 Jun 2016 08:54:51 -0400 Received: from e06smtp17.uk.ibm.com (e06smtp17.uk.ibm.com [195.75.94.113]) by mx0a-001b2d01.pphosted.com with ESMTP id 23v09qnq3h-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Thu, 30 Jun 2016 08:54:51 -0400 Received: from localhost by e06smtp17.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 30 Jun 2016 13:54:49 +0100 Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 4FDEB1B08074 for ; Thu, 30 Jun 2016 13:56:01 +0100 (BST) Received: from d06av08.portsmouth.uk.ibm.com (d06av08.portsmouth.uk.ibm.com [9.149.37.249]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u5UCsjdp64094462 for ; Thu, 30 Jun 2016 12:54:45 GMT Received: from d06av08.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av08.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u5UCsjbe009258 for ; Thu, 30 Jun 2016 06:54:45 -0600 Date: Thu, 30 Jun 2016 14:54:44 +0200 From: Greg Kurz In-Reply-To: <5a0ead6f1c95daba4a019ea1e9382e51.squirrel@mifritscher.de> References: <20160413131513.31708.89296.stgit@bahia.huguette.org> <20160413131520.31708.12050.stgit@bahia.huguette.org> <66efbc38-69e5-55b4-017f-78f96a3331a3@kaod.org> <5a0ead6f1c95daba4a019ea1e9382e51.squirrel@mifritscher.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Message-Id: <20160630145444.557d319d@bahia.lan> Subject: Re: [Qemu-devel] [PATCH for-2.7 1/2] 9p: don't include List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Fritscher Cc: =?UTF-8?B?Q8ODwqlkcmlj?= Le Goater , "Aneesh Kumar K.V" , qemu-devel@nongnu.org, Greg Kurz On Thu, 30 Jun 2016 14:42:05 +0200 "Michael Fritscher" wrote: > > On 04/13/2016 03:15 PM, Greg Kurz wrote: =20 > >> The system header doesn't exist on all host platforms. Code > >> should > >> include "qemu/osdep.h" instead to avoid build breaks on plafforms that > >> don't > >> define CONFIG_IOVEC (like win32, if it is to support 9p one day). > >> > >> Signed-off-by: Greg Kurz =20 > > > > Acked-by: C=C3=83=C2=A9dric Le Goater =20 > Acked-by: Michael Fritscher >=20 > Yes, I still plan to upstream the win32 9p support in the next weeks, when > my stress level goes down a bit ;-) >=20 Hi Michael ! FYI I'll be on a 1-month leave, starting 25th of July, during which I'm lik= ely to be fully disconnected... Cheers. -- Greg > Best regards, > Michael Fritscher >=20 > >> --- > >> fsdev/9p-iov-marshal.c | 1 - > >> fsdev/9p-marshal.c | 1 - > >> fsdev/file-op-9p.h | 2 +- > >> 3 files changed, 1 insertion(+), 3 deletions(-) > >> > >> diff --git a/fsdev/9p-iov-marshal.c b/fsdev/9p-iov-marshal.c > >> index fb40bdf0d5f6..a564637b73c1 100644 > >> --- a/fsdev/9p-iov-marshal.c > >> +++ b/fsdev/9p-iov-marshal.c > >> @@ -15,7 +15,6 @@ > >> #include > >> #include > >> #include > >> -#include > >> > >> #include "9p-iov-marshal.h" > >> #include "qemu/bswap.h" > >> diff --git a/fsdev/9p-marshal.c b/fsdev/9p-marshal.c > >> index 183d3667c681..df9d4f8e23c9 100644 > >> --- a/fsdev/9p-marshal.c > >> +++ b/fsdev/9p-marshal.c > >> @@ -16,7 +16,6 @@ > >> #include > >> #include > >> #include > >> -#include > >> > >> #include "9p-marshal.h" > >> > >> diff --git a/fsdev/file-op-9p.h b/fsdev/file-op-9p.h > >> index b8c26024a955..8736d1fa6d52 100644 > >> --- a/fsdev/file-op-9p.h > >> +++ b/fsdev/file-op-9p.h > >> @@ -12,9 +12,9 @@ > >> */ > >> #ifndef _FILEOP_H > >> #define _FILEOP_H > >> +#include "qemu/osdep.h" > >> #include > >> #include > >> -#include > >> #include > >> > >> #define SM_LOCAL_MODE_BITS 0600 > >> > >> =20 > > > > =20 >=20 >=20