From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44294) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bIefU-00039S-8E for qemu-devel@nongnu.org; Thu, 30 Jun 2016 12:18:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bIefS-00058X-8p for qemu-devel@nongnu.org; Thu, 30 Jun 2016 12:18:19 -0400 Date: Thu, 30 Jun 2016 12:18:09 -0400 From: Jeff Cody Message-ID: <20160630161809.GD17242@localhost.localdomain> References: <1466598927-5990-1-git-send-email-den@openvz.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1466598927-5990-1-git-send-email-den@openvz.org> Subject: Re: [Qemu-devel] [PATCH 1/1] mirror: fix request throttling in drive-mirror List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, Kevin Wolf , Max Reitz On Wed, Jun 22, 2016 at 03:35:27PM +0300, Denis V. Lunev wrote: > There are 2 deficiencies here: > - mirror_iteration could start several requests inside. Thus we could > simply have more in_flight requests than MAX_IN_FLIGHT. > - keeping this in mind throttling in mirror_run which is checking > s->in_flight == MAX_IN_FLIGHT is wrong. > > The patch adds the check and throttling into mirror_iteration and fixes > the check in mirror_run() to be sure. > > Signed-off-by: Denis V. Lunev > CC: Jeff Cody > CC: Kevin Wolf > CC: Max Reitz > --- > block/mirror.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/block/mirror.c b/block/mirror.c > index a04ed9c..e881ef6 100644 > --- a/block/mirror.c > +++ b/block/mirror.c > @@ -399,6 +399,11 @@ static uint64_t coroutine_fn mirror_iteration(MirrorBlockJob *s) > } > } > > + while (s->in_flight >= MAX_IN_FLIGHT) { > + trace_mirror_yield_in_flight(s, sector_num, s->in_flight); > + mirror_wait_for_io(s); > + } > + > mirror_clip_sectors(s, sector_num, &io_sectors); > switch (mirror_method) { > case MIRROR_METHOD_COPY: > @@ -634,7 +639,7 @@ static void coroutine_fn mirror_run(void *opaque) > */ > if (qemu_clock_get_ns(QEMU_CLOCK_REALTIME) - last_pause_ns < SLICE_TIME && > s->common.iostatus == BLOCK_DEVICE_IO_STATUS_OK) { > - if (s->in_flight == MAX_IN_FLIGHT || s->buf_free_count == 0 || > + if (s->in_flight >= MAX_IN_FLIGHT || s->buf_free_count == 0 || > (cnt == 0 && s->in_flight > 0)) { > trace_mirror_yield(s, s->in_flight, s->buf_free_count, cnt); > mirror_wait_for_io(s); > -- > 2.1.4 > Thanks, Applied to my block branch: git://github.com/codyprime/qemu-kvm-jtc.git block -Jeff