From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53477)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1bIhFq-0003iB-Og
	for qemu-devel@nongnu.org; Thu, 30 Jun 2016 15:04:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1bIhFl-0008OL-BH
	for qemu-devel@nongnu.org; Thu, 30 Jun 2016 15:04:02 -0400
Received: from mx1.redhat.com ([209.132.183.28]:58194)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1bIhFl-0008Nv-57
	for qemu-devel@nongnu.org; Thu, 30 Jun 2016 15:03:57 -0400
Date: Thu, 30 Jun 2016 20:03:52 +0100
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Message-ID: <20160630190352.GB2248@work-vm>
References: <1467310337-3201-1-git-send-email-ehabkost@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1467310337-3201-1-git-send-email-ehabkost@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] target-i386: Show host and VM TSC
 frequencies on mismatch
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org, Marcelo Tosatti <mtosatti@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, haozhong.zhang@intel.com

* Eduardo Habkost (ehabkost@redhat.com) wrote:
> Improve the TSC frequency mismatch warning to show the host and
> VM TSC frequencies.
> 
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>  target-i386/kvm.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/target-i386/kvm.c b/target-i386/kvm.c
> index f3698f1..9679415 100644
> --- a/target-i386/kvm.c
> +++ b/target-i386/kvm.c
> @@ -566,7 +566,9 @@ static int kvm_arch_set_tsc_khz(CPUState *cs)
>                         -ENOTSUP;
>          if (cur_freq <= 0 || cur_freq != env->tsc_khz) {
>              error_report("warning: TSC frequency mismatch between "
> -                         "VM and host, and TSC scaling unavailable");
> +                         "VM (%" PRId64 " kHz) and host (%d kHz), "
> +                         "and TSC scaling unavailable",
> +                         env->tsc_khz, cur_freq);
>              return r;
>          }

Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

Yep, it should be interesting to see what the differences are we hit,
wacky different values or the one next door that's slightly warmer.

Dave

>      }
> -- 
> 2.5.5
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK