From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53518) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bIhGF-0003xJ-DG for qemu-devel@nongnu.org; Thu, 30 Jun 2016 15:04:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bIhGB-0008Tu-Gy for qemu-devel@nongnu.org; Thu, 30 Jun 2016 15:04:26 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:1691) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bIhGB-0008Tb-7v for qemu-devel@nongnu.org; Thu, 30 Jun 2016 15:04:23 -0400 Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u5UJ3d5N051615 for ; Thu, 30 Jun 2016 15:04:22 -0400 Received: from e37.co.us.ibm.com (e37.co.us.ibm.com [32.97.110.158]) by mx0a-001b2d01.pphosted.com with ESMTP id 23uuhveb1v-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Thu, 30 Jun 2016 15:04:22 -0400 Received: from localhost by e37.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 30 Jun 2016 13:04:21 -0600 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Michael Roth In-Reply-To: <1465572354-3083-1-git-send-email-thuth@redhat.com> References: <1465572354-3083-1-git-send-email-thuth@redhat.com> Date: Thu, 30 Jun 2016 14:04:15 -0500 Message-Id: <20160630190415.6192.5429@loki> Subject: Re: [Qemu-devel] [PATCH] configure: Rename CONFIG_QGA_NTDDDISK into CONFIG_QGA_NTDDSCSI List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org Quoting Thomas Huth (2016-06-10 10:25:54) > There is no CONFIG_QGA_NTDDDISK define used anywhere in the QEMU > sources. Looking at the changelog and qga/commands-win32.c, it > seems like this should be called CONFIG_QGA_NTDDSCSI instead. > = > Signed-off-by: Thomas Huth Thanks, applied to qga tree: https://github.com/mdroth/qemu/commits/qga Although this did indeed uncover a bug in guest-get-fsinfo. Should have a fix soon, but will want that in place before I send a pull. > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > = > diff --git a/configure b/configure > index 8c2f90b..55019d6 100755 > --- a/configure > +++ b/configure > @@ -4965,7 +4965,7 @@ if test "$mingw32" =3D "yes" ; then > echo "WIN_SDK=3D\"$win_sdk\"" >> $config_host_mak > fi > if test "$guest_agent_ntddscsi" =3D "yes" ; then > - echo "CONFIG_QGA_NTDDDISK=3Dy" >> $config_host_mak > + echo "CONFIG_QGA_NTDDSCSI=3Dy" >> $config_host_mak > fi > if test "$guest_agent_msi" =3D "yes"; then > echo "QEMU_GA_MSI_ENABLED=3Dyes" >> $config_host_mak = > -- = > 1.8.3.1 >=20