From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35434) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bIg46-0004zG-T9 for qemu-devel@nongnu.org; Thu, 30 Jun 2016 13:47:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bIg43-0005v6-Eq for qemu-devel@nongnu.org; Thu, 30 Jun 2016 13:47:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36665) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bIg43-0005v2-8n for qemu-devel@nongnu.org; Thu, 30 Jun 2016 13:47:47 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 86A833B70D for ; Thu, 30 Jun 2016 17:47:46 +0000 (UTC) Date: Thu, 30 Jun 2016 20:47:33 +0300 From: "Michael S. Tsirkin" Message-ID: <20160630202451-mutt-send-email-mst@redhat.com> References: <1467289387-47575-1-git-send-email-imammedo@redhat.com> <1467289387-47575-4-git-send-email-imammedo@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1467289387-47575-4-git-send-email-imammedo@redhat.com> Subject: Re: [Qemu-devel] [PATCH 3/4] acpi: provide _PXM method for CPU devices if QEMU is started numa enabled List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: qemu-devel@nongnu.org, marcel@redhat.com On Thu, Jun 30, 2016 at 02:23:06PM +0200, Igor Mammedov wrote: > fixes long standing issue where Linux kernel would assing assign? > hotplugged CPU to 1st numa node as it discards proximity > for hotplugged CPUs after SRAT is parsed. > > Signed-off-by: Igor Mammedov > --- > hw/acpi/cpu.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/hw/acpi/cpu.c b/hw/acpi/cpu.c > index c13b65c..d9cf3ee 100644 > --- a/hw/acpi/cpu.c > +++ b/hw/acpi/cpu.c > @@ -4,6 +4,7 @@ > #include "qapi/error.h" > #include "qapi-event.h" > #include "trace.h" > +#include "sysemu/numa.h" > > #define ACPI_CPU_HOTPLUG_REG_LEN 12 > #define ACPI_CPU_SELECTOR_OFFSET_WR 0 > @@ -503,6 +504,7 @@ void build_cpus_aml(Aml *table, MachineState *machine, CPUHotplugFeatures opts, > > /* build Processor object for each processor */ > for (i = 0; i < arch_ids->len; i++) { > + int j; > Aml *dev; > Aml *uid = aml_int(i); > GArray *madt_buf = g_array_new(0, 1, 1); > @@ -546,6 +548,13 @@ void build_cpus_aml(Aml *table, MachineState *machine, CPUHotplugFeatures opts, > aml_arg(1), aml_arg(2)) > ); > aml_append(dev, method); > + > + for (j = 0; j < nb_numa_nodes; j++) { > + if (test_bit(i, numa_info[j].node_cpu)) { > + aml_append(dev, aml_name_decl("_PXM", aml_int(j))); > + } > + } this code is duplicated in a couple of other places. how about a helper to find the numa node for a CPU? > + > aml_append(cpus_dev, dev); > } > } I'd like a comment here explaining why it's needed. E.g. /* * Linux guests discard SRAT info for non-present CPUs * as a result _PXM is required for all CPUs which might * be hot-plugged. For simplicity, add it for all CPUs. */ > -- > 1.8.3.1