* [Qemu-devel] [PATCH] qmp: fix spapr example of query-hotpluggable-cpus
@ 2016-06-30 8:17 Igor Mammedov
2016-06-30 8:30 ` Peter Krempa
0 siblings, 1 reply; 3+ messages in thread
From: Igor Mammedov @ 2016-06-30 8:17 UTC (permalink / raw)
To: qemu-devel; +Cc: armbru, pkrempa, david
27393c33 qapi: keep names in 'CpuInstanceProperties' in sync with struct CPUCore
added -id suffix to property names but forgot to fix example in qmp-commands.hx
Fix example to have 'core-id' instead of 'core' to match current code
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
qmp-commands.hx | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/qmp-commands.hx b/qmp-commands.hx
index b444c20..6937e83 100644
--- a/qmp-commands.hx
+++ b/qmp-commands.hx
@@ -4978,8 +4978,8 @@ Example for pseries machine type started with
-> { "execute": "query-hotpluggable-cpus" }
<- {"return": [
- { "props": { "core": 8 }, "type": "POWER8-spapr-cpu-core",
+ { "props": { "core-id": 8 }, "type": "POWER8-spapr-cpu-core",
"vcpus-count": 1 },
- { "props": { "core": 0 }, "type": "POWER8-spapr-cpu-core",
+ { "props": { "core-id": 0 }, "type": "POWER8-spapr-cpu-core",
"vcpus-count": 1, "qom-path": "/machine/unattached/device[0]"}
]}'
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] qmp: fix spapr example of query-hotpluggable-cpus
2016-06-30 8:17 [Qemu-devel] [PATCH] qmp: fix spapr example of query-hotpluggable-cpus Igor Mammedov
@ 2016-06-30 8:30 ` Peter Krempa
2016-07-01 0:15 ` David Gibson
0 siblings, 1 reply; 3+ messages in thread
From: Peter Krempa @ 2016-06-30 8:30 UTC (permalink / raw)
To: Igor Mammedov; +Cc: qemu-devel, armbru, david
On Thu, Jun 30, 2016 at 10:17:54 +0200, Igor Mammedov wrote:
> 27393c33 qapi: keep names in 'CpuInstanceProperties' in sync with struct CPUCore
> added -id suffix to property names but forgot to fix example in qmp-commands.hx
>
> Fix example to have 'core-id' instead of 'core' to match current code
>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> ---
> qmp-commands.hx | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Oops; thanks for cleaning up after me.
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] qmp: fix spapr example of query-hotpluggable-cpus
2016-06-30 8:30 ` Peter Krempa
@ 2016-07-01 0:15 ` David Gibson
0 siblings, 0 replies; 3+ messages in thread
From: David Gibson @ 2016-07-01 0:15 UTC (permalink / raw)
To: Peter Krempa; +Cc: Igor Mammedov, qemu-devel, armbru
[-- Attachment #1: Type: text/plain, Size: 866 bytes --]
On Thu, Jun 30, 2016 at 10:30:53AM +0200, Peter Krempa wrote:
> On Thu, Jun 30, 2016 at 10:17:54 +0200, Igor Mammedov wrote:
> > 27393c33 qapi: keep names in 'CpuInstanceProperties' in sync with struct CPUCore
> > added -id suffix to property names but forgot to fix example in qmp-commands.hx
> >
> > Fix example to have 'core-id' instead of 'core' to match current code
> >
> > Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> > ---
> > qmp-commands.hx | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Oops; thanks for cleaning up after me.
>
> Reviewed-by: Peter Krempa <pkrempa@redhat.com>
Applied to ppc-for-2.7, thanks.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-07-01 0:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-30 8:17 [Qemu-devel] [PATCH] qmp: fix spapr example of query-hotpluggable-cpus Igor Mammedov
2016-06-30 8:30 ` Peter Krempa
2016-07-01 0:15 ` David Gibson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).