* [Qemu-devel] [PATCH] target-i386: Show host and VM TSC frequencies on mismatch
@ 2016-06-30 18:12 Eduardo Habkost
2016-06-30 19:03 ` Dr. David Alan Gilbert
2016-07-01 1:01 ` Marcelo Tosatti
0 siblings, 2 replies; 3+ messages in thread
From: Eduardo Habkost @ 2016-06-30 18:12 UTC (permalink / raw)
To: qemu-devel
Cc: Marcelo Tosatti, Dr. David Alan Gilbert, Paolo Bonzini,
haozhong.zhang
Improve the TSC frequency mismatch warning to show the host and
VM TSC frequencies.
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
target-i386/kvm.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/target-i386/kvm.c b/target-i386/kvm.c
index f3698f1..9679415 100644
--- a/target-i386/kvm.c
+++ b/target-i386/kvm.c
@@ -566,7 +566,9 @@ static int kvm_arch_set_tsc_khz(CPUState *cs)
-ENOTSUP;
if (cur_freq <= 0 || cur_freq != env->tsc_khz) {
error_report("warning: TSC frequency mismatch between "
- "VM and host, and TSC scaling unavailable");
+ "VM (%" PRId64 " kHz) and host (%d kHz), "
+ "and TSC scaling unavailable",
+ env->tsc_khz, cur_freq);
return r;
}
}
--
2.5.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] target-i386: Show host and VM TSC frequencies on mismatch
2016-06-30 18:12 [Qemu-devel] [PATCH] target-i386: Show host and VM TSC frequencies on mismatch Eduardo Habkost
@ 2016-06-30 19:03 ` Dr. David Alan Gilbert
2016-07-01 1:01 ` Marcelo Tosatti
1 sibling, 0 replies; 3+ messages in thread
From: Dr. David Alan Gilbert @ 2016-06-30 19:03 UTC (permalink / raw)
To: Eduardo Habkost
Cc: qemu-devel, Marcelo Tosatti, Paolo Bonzini, haozhong.zhang
* Eduardo Habkost (ehabkost@redhat.com) wrote:
> Improve the TSC frequency mismatch warning to show the host and
> VM TSC frequencies.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> target-i386/kvm.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/target-i386/kvm.c b/target-i386/kvm.c
> index f3698f1..9679415 100644
> --- a/target-i386/kvm.c
> +++ b/target-i386/kvm.c
> @@ -566,7 +566,9 @@ static int kvm_arch_set_tsc_khz(CPUState *cs)
> -ENOTSUP;
> if (cur_freq <= 0 || cur_freq != env->tsc_khz) {
> error_report("warning: TSC frequency mismatch between "
> - "VM and host, and TSC scaling unavailable");
> + "VM (%" PRId64 " kHz) and host (%d kHz), "
> + "and TSC scaling unavailable",
> + env->tsc_khz, cur_freq);
> return r;
> }
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Yep, it should be interesting to see what the differences are we hit,
wacky different values or the one next door that's slightly warmer.
Dave
> }
> --
> 2.5.5
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] target-i386: Show host and VM TSC frequencies on mismatch
2016-06-30 18:12 [Qemu-devel] [PATCH] target-i386: Show host and VM TSC frequencies on mismatch Eduardo Habkost
2016-06-30 19:03 ` Dr. David Alan Gilbert
@ 2016-07-01 1:01 ` Marcelo Tosatti
1 sibling, 0 replies; 3+ messages in thread
From: Marcelo Tosatti @ 2016-07-01 1:01 UTC (permalink / raw)
To: Eduardo Habkost
Cc: qemu-devel, Dr. David Alan Gilbert, Paolo Bonzini, haozhong.zhang
On Thu, Jun 30, 2016 at 03:12:17PM -0300, Eduardo Habkost wrote:
> Improve the TSC frequency mismatch warning to show the host and
> VM TSC frequencies.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> target-i386/kvm.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/target-i386/kvm.c b/target-i386/kvm.c
> index f3698f1..9679415 100644
> --- a/target-i386/kvm.c
> +++ b/target-i386/kvm.c
> @@ -566,7 +566,9 @@ static int kvm_arch_set_tsc_khz(CPUState *cs)
> -ENOTSUP;
> if (cur_freq <= 0 || cur_freq != env->tsc_khz) {
> error_report("warning: TSC frequency mismatch between "
> - "VM and host, and TSC scaling unavailable");
> + "VM (%" PRId64 " kHz) and host (%d kHz), "
> + "and TSC scaling unavailable",
> + env->tsc_khz, cur_freq);
> return r;
> }
> }
> --
> 2.5.5
ACK
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-07-01 2:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-30 18:12 [Qemu-devel] [PATCH] target-i386: Show host and VM TSC frequencies on mismatch Eduardo Habkost
2016-06-30 19:03 ` Dr. David Alan Gilbert
2016-07-01 1:01 ` Marcelo Tosatti
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).