From: Greg Kurz <groug@kaod.org>
To: "Cédric Le Goater" <clg@kaod.org>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Peter Crosthwaite <crosthwaite.peter@gmail.com>,
QEMU Developers <qemu-devel@nongnu.org>,
qemu-arm <qemu-arm@nongnu.org>, Kevin Wolf <kwolf@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Andrew Jeffery <andrew@aj.id.au>
Subject: Re: [Qemu-devel] [PATCH v5 9/9] tests: add a m25p80 test
Date: Fri, 1 Jul 2016 23:46:33 +0200 [thread overview]
Message-ID: <20160701234633.7e073c2f@bahia.lan> (raw)
In-Reply-To: <39c0c830-dd0b-301f-78fc-6de176772a7c@kaod.org>
On Fri, 1 Jul 2016 19:30:30 +0200
Cédric Le Goater <clg@kaod.org> wrote:
> On 07/01/2016 07:18 PM, Peter Maydell wrote:
> > On 28 June 2016 at 19:24, Cédric Le Goater <clg@kaod.org> wrote:
> >> This test uses the palmetto platform and the AST2400 SPI controller to
> >> test the m25p80 flash module device model. The flash model is defined
> >> by the platform (n25q256a) and it would be nice to find way to control
> >> it, using a property probably.
> >>
> >> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> >> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> >> ---
> >>
> >
> > This test fails on ppc64be:
> >
> > TEST: tests/m25p80-test... (pid=65123)
> > /arm/m25p80/read_jedec: OK
> > /arm/m25p80/erase_sector: OK
> > /arm/m25p80/erase_all: **
> > ERROR:/home/pm215/qemu/tests/m25p80-test.c:162:test_erase_all:
> > assertion failed (page[i] == 0x0):
> > (0xffffffff == 0x00000000)
> > FAIL
> > GTester: last random seed: R02S54b2016fda21b092e18d7a23a2db86ba
> > (pid=65128)
> > /arm/m25p80/write_page: **
> > ERROR:/home/pm215/qemu/tests/m25p80-test.c:200:test_write_page:
> > assertion failed (page[i] == my_page_addr + i * 4): (0x00000000 ==
> > 0x01400000)
> > FAIL
> > GTester: last random seed: R02S8708910d6b72f700bc41e9340a516239
> > (pid=65133)
> > FAIL: tests/m25p80-test
>
> yes ... I am not sure how to fix this :/
>
> I started with a patch using qtest_big_endian() and I found that
> this one was fixing the problem :
>
> https://lists.gnu.org/archive/html/qemu-devel/2016-06/msg07876.html
>
> but it feels wrong. The interesting part is that the guest fully
> boots on a ppc64be. We need an endian shaman for this. Greg ?
>
Heh ! Looking at the Cc list I guess you have chances to find the
shaman you're looking for :)
Anyway, doing bswap32() systematically like in the patch mentioned above
looks weird indeed.
> Thanks,
>
> C.
next prev parent reply other threads:[~2016-07-01 21:46 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-28 18:24 [Qemu-devel] [PATCH v5 0/9] ast2400: SMC controllers Cédric Le Goater
2016-06-28 18:24 ` [Qemu-devel] [PATCH v5 1/9] ssi: change ssi_slave_init to be a realize ops Cédric Le Goater
2016-07-01 15:16 ` Peter Maydell
2016-06-28 18:24 ` [Qemu-devel] [PATCH v5 2/9] m25p80: do not put iovec on the stack Cédric Le Goater
2016-06-28 18:24 ` [Qemu-devel] [PATCH v5 3/9] m25p80: avoid out of bounds accesses Cédric Le Goater
2016-06-28 18:24 ` [Qemu-devel] [PATCH v5 4/9] m25p80: change cur_addr to 32 bit integer Cédric Le Goater
2016-06-28 18:24 ` [Qemu-devel] [PATCH v5 5/9] m25p80: qdev-ify drive property Cédric Le Goater
2016-06-28 18:24 ` [Qemu-devel] [PATCH v5 6/9] ast2400: add SMC controllers (FMC and SPI) Cédric Le Goater
2016-06-29 7:58 ` Cédric Le Goater
2016-07-02 17:00 ` mar.krzeminski
2016-07-04 6:58 ` Cédric Le Goater
2016-07-04 7:12 ` Marcin Krzemiński
2016-06-28 18:24 ` [Qemu-devel] [PATCH v5 7/9] ast2400: add SPI flash slaves Cédric Le Goater
2016-07-01 16:24 ` Peter Maydell
2016-07-01 16:44 ` Cédric Le Goater
2016-07-01 17:00 ` Peter Maydell
2016-07-02 17:08 ` mar.krzeminski
2016-07-02 17:51 ` mar.krzeminski
2016-06-28 18:24 ` [Qemu-devel] [PATCH v5 8/9] ast2400: create " Cédric Le Goater
2016-07-01 15:19 ` Peter Maydell
2016-06-28 18:24 ` [Qemu-devel] [PATCH v5 9/9] tests: add a m25p80 test Cédric Le Goater
2016-07-01 17:18 ` Peter Maydell
2016-07-01 17:22 ` Peter Maydell
2016-07-01 17:30 ` Cédric Le Goater
2016-07-01 21:46 ` Greg Kurz [this message]
2016-07-02 18:05 ` mar.krzeminski
2016-07-04 9:15 ` Cédric Le Goater
2016-07-04 9:50 ` Cédric Le Goater
2016-07-04 11:14 ` Peter Maydell
2016-07-04 12:01 ` Cédric Le Goater
2016-07-04 12:11 ` Peter Maydell
2016-07-04 12:32 ` Cédric Le Goater
2016-07-01 16:25 ` [Qemu-devel] [PATCH v5 0/9] ast2400: SMC controllers Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160701234633.7e073c2f@bahia.lan \
--to=groug@kaod.org \
--cc=andrew@aj.id.au \
--cc=armbru@redhat.com \
--cc=clg@kaod.org \
--cc=crosthwaite.peter@gmail.com \
--cc=kwolf@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).