qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: qemu-devel@nongnu.org, zhaoshenglong@huawei.com,
	peter.maydell@linaro.org, david@gibson.dropbear.id.au,
	marcel@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3 5/5] tests: acpi: extend cphp testcase with numa check
Date: Mon, 4 Jul 2016 15:14:40 +0300	[thread overview]
Message-ID: <20160704151408-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <1467373826-110305-6-git-send-email-imammedo@redhat.com>

On Fri, Jul 01, 2016 at 01:50:26PM +0200, Igor Mammedov wrote:
> so it would be possible to verify _PXM generation in
> DSDT and SRAT tables.
> 
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> Reviewed-by: Marcel Apfelbaum <marcel@redhat.com>

It's still a pain to backport, pls make it a separate patch if
you repost.

> ---
> NOTE to maintainer:
> SRAT table is included in patch as it doesn't have
> any chance for conflicts compared to often changing
> DSDT
> 
> following table blobs should be updated in git tree as part
> of this commit after running ./tests/acpi-test-data/rebuild-expected-aml.sh
> 
> tests/acpi-test-data/q35/DSDT.cphp
> tests/acpi-test-data/pc/DSDT.cphp
> ---
>  tests/acpi-test-data/pc/SRAT.cphp  | Bin 0 -> 304 bytes
>  tests/acpi-test-data/q35/SRAT.cphp | Bin 0 -> 304 bytes
>  tests/bios-tables-test.c           |   6 ++++--
>  3 files changed, 4 insertions(+), 2 deletions(-)
>  create mode 100644 tests/acpi-test-data/pc/SRAT.cphp
>  create mode 100644 tests/acpi-test-data/q35/SRAT.cphp
> 
> diff --git a/tests/acpi-test-data/pc/SRAT.cphp b/tests/acpi-test-data/pc/SRAT.cphp
> new file mode 100644
> index 0000000000000000000000000000000000000000..ff2137642f488ec70b85207ed6c20e7351d61e98
> GIT binary patch
> literal 304
> zcmWFzattwGWME)4bMklg2v%^42yhMtiUEZfKx_~V!f+sf!DmF1XF}yOvY_!<(fDl0
> pd`1npO;83GTmZW|po75R12aq^syaB21u74tQT&BzFU&Ml8UVWm2>}2A
> 
> literal 0
> HcmV?d00001
> 
> diff --git a/tests/acpi-test-data/q35/SRAT.cphp b/tests/acpi-test-data/q35/SRAT.cphp
> new file mode 100644
> index 0000000000000000000000000000000000000000..ff2137642f488ec70b85207ed6c20e7351d61e98
> GIT binary patch
> literal 304
> zcmWFzattwGWME)4bMklg2v%^42yhMtiUEZfKx_~V!f+sf!DmF1XF}yOvY_!<(fDl0
> pd`1npO;83GTmZW|po75R12aq^syaB21u74tQT&BzFU&Ml8UVWm2>}2A
> 
> literal 0
> HcmV?d00001
> 
> diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c
> index de4019e..3796089 100644
> --- a/tests/bios-tables-test.c
> +++ b/tests/bios-tables-test.c
> @@ -809,7 +809,8 @@ static void test_acpi_piix4_tcg_cphp(void)
>      data.machine = MACHINE_PC;
>      data.variant = ".cphp";
>      test_acpi_one("-machine accel=tcg"
> -                  " -smp 2,cores=3,sockets=2,maxcpus=6",
> +                  " -smp 2,cores=3,sockets=2,maxcpus=6"
> +                  " -numa node -numa node",
>                    &data);
>      free_test_data(&data);
>  }
> @@ -822,7 +823,8 @@ static void test_acpi_q35_tcg_cphp(void)
>      data.machine = MACHINE_Q35;
>      data.variant = ".cphp";
>      test_acpi_one("-machine q35,accel=tcg"
> -                  " -smp 2,cores=3,sockets=2,maxcpus=6",
> +                  " -smp 2,cores=3,sockets=2,maxcpus=6"
> +                  " -numa node -numa node",
>                    &data);
>      free_test_data(&data);
>  }
> -- 
> 1.8.3.1

  reply	other threads:[~2016-07-04 12:14 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-01 11:50 [Qemu-devel] [PATCH v3 0/5] fix numa node mapping for hotplugged CPUs Igor Mammedov
2016-07-01 11:50 ` [Qemu-devel] [PATCH v3 1/5] tests: acpi: add CPU hotplug testcase Igor Mammedov
2016-07-01 11:50 ` [Qemu-devel] [PATCH v3 2/5] tests: DO NOT APPLY: add APIC.cphp and DSDT.cphp blobs Igor Mammedov
2016-07-01 11:50 ` [Qemu-devel] [PATCH v3 3/5] numa: reduce code duplication by adding helper numa_get_node_for_cpu() Igor Mammedov
2016-07-01 12:30   ` Andrew Jones
2016-07-04  7:06     ` Igor Mammedov
2016-07-07 12:03       ` Andrew Jones
2016-07-04  3:34   ` David Gibson
2016-07-04 12:13   ` Michael S. Tsirkin
2016-07-01 11:50 ` [Qemu-devel] [PATCH v3 4/5] acpi: provide _PXM method for CPU devices if QEMU is started numa enabled Igor Mammedov
2016-07-01 11:50 ` [Qemu-devel] [PATCH v3 5/5] tests: acpi: extend cphp testcase with numa check Igor Mammedov
2016-07-04 12:14   ` Michael S. Tsirkin [this message]
2016-07-04 12:49     ` Igor Mammedov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160704151408-mutt-send-email-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=imammedo@redhat.com \
    --cc=marcel@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=zhaoshenglong@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).