From: Fam Zheng <famz@redhat.com>
To: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH] json-streamer: fix double-free on exiting during a parse
Date: Tue, 5 Jul 2016 15:19:16 +0800 [thread overview]
Message-ID: <20160705071916.GC29307@ad.usersys.redhat.com> (raw)
In-Reply-To: <577B5EC2.40709@cn.fujitsu.com>
On Tue, 07/05 15:16, Changlong Xie wrote:
> On 07/05/2016 02:56 PM, Fam Zheng wrote:
> > On Mon, 07/04 14:40, Paolo Bonzini wrote:
> > > Now that json-streamer tries not to leak tokens on incomplete parse,
> > > the tokens can be freed twice if QEMU destroys the json-streamer
> > > object during the parser->emit call. To fix this, create the new
> > > empty GQueue earlier, so that it is already in place when the old
> > > one is passed to parser->emit.
> > >
> > > Reported-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
> > > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> >
> > Two meta questions:
> >
> > Is there a reproducer and/or test case coverage?
>
> tests/qemu-iotests/071
>
> >
> > Does qemu-stable need this?
> >
>
> http://lists.nongnu.org/archive/html/qemu-devel/2016-07/msg00465.html
Get it! Thanks!
Fam
next prev parent reply other threads:[~2016-07-05 7:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-04 12:40 [Qemu-devel] [PATCH] json-streamer: fix double-free on exiting during a parse Paolo Bonzini
2016-07-05 6:56 ` Fam Zheng
2016-07-05 7:16 ` Changlong Xie
2016-07-05 7:19 ` Fam Zheng [this message]
2016-07-05 12:51 ` Eric Blake
2016-07-06 14:30 ` Markus Armbruster
2016-07-06 14:45 ` Paolo Bonzini
2016-07-06 15:06 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160705071916.GC29307@ad.usersys.redhat.com \
--to=famz@redhat.com \
--cc=armbru@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=xiecl.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).