From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60624)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kevin@koconnor.net>) id 1bKQir-0003fj-9e
	for qemu-devel@nongnu.org; Tue, 05 Jul 2016 09:49:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kevin@koconnor.net>) id 1bKQin-0003SR-4J
	for qemu-devel@nongnu.org; Tue, 05 Jul 2016 09:49:08 -0400
Received: from mail-qk0-x233.google.com ([2607:f8b0:400d:c09::233]:34653)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kevin@koconnor.net>) id 1bKQim-0003SH-WE
	for qemu-devel@nongnu.org; Tue, 05 Jul 2016 09:49:05 -0400
Received: by mail-qk0-x233.google.com with SMTP id t127so288403078qkf.1
	for <qemu-devel@nongnu.org>; Tue, 05 Jul 2016 06:49:04 -0700 (PDT)
Date: Tue, 5 Jul 2016 09:49:02 -0400
From: Kevin O'Connor <kevin@koconnor.net>
Message-ID: <20160705134902.GA2939@morn.lan>
References: <1467664794-31002-1-git-send-email-kraxel@redhat.com>
	<1467664794-31002-2-git-send-email-kraxel@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1467664794-31002-2-git-send-email-kraxel@redhat.com>
Subject: Re: [Qemu-devel] [SeaBIOS] [PATCH 1/3] std: add cp437 to unicode map
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: seabios@seabios.org, qemu-devel@nongnu.org

On Mon, Jul 04, 2016 at 10:39:52PM +0200, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

Nice!

[...]
> --- /dev/null
> +++ b/src/std/cp437.h

Instead of making a header file and including it in an array in the C
code I think it would be better to instead introduce cp437.c with:

u16 sercon_cp437[256] VARFSEG = {
   ...
};

[...]
> +[ 0x7f ] = 0x007f, //  DELETE

That should be 0x2302 (see the wikipedia page).

-Kevin