From: Kevin Wolf <kwolf@redhat.com>
To: "Denis V. Lunev" <den@openvz.org>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org,
Eric Blake <eblake@redhat.com>, Max Reitz <mreitz@redhat.com>,
stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/1] qemu-img: fix failed autotests
Date: Tue, 5 Jul 2016 16:52:34 +0200 [thread overview]
Message-ID: <20160705145234.GD5882@noname.redhat.com> (raw)
In-Reply-To: <1467638208-26198-1-git-send-email-den@openvz.org>
Am 04.07.2016 um 15:16 hat Denis V. Lunev geschrieben:
> There are 9 iotests failed on Ubuntu 15.10 at the moment.
> The problem is that options parsing in qemu-img is broken by the
> following commit:
> commit 10985131e337a0c52c5bd1e191fd7867a6ff8d02
> Author: Denis V. Lunev <den@openvz.org>
> Date: Fri Jun 17 17:44:13 2016 +0300
> qemu-img: move common options parsing before commands processing
>
> This strange command line reports error
> ./qemu-img create -f qcow2 TEST_DIR/t.qcow2 -- 1024
> qemu-img: Invalid image size specified!
> while original code parses it successfully.
>
> The problem is that getopt_long state should be reset. This could be done
> using this assignment according to the manual:
> optind = 0
>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> CC: Eric Blake <eblake@redhat.com>
> CC: Kevin Wolf <kwolf@redhat.com>
> CC: Max Reitz <mreitz@redhat.com>
Thanks, applied to the block branch.
Stefan, don't you run qemu-iotests any more before sending pull
requests?
Kevin
prev parent reply other threads:[~2016-07-05 14:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-04 13:16 [Qemu-devel] [PATCH 1/1] qemu-img: fix failed autotests Denis V. Lunev
2016-07-05 14:52 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160705145234.GD5882@noname.redhat.com \
--to=kwolf@redhat.com \
--cc=den@openvz.org \
--cc=eblake@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).