From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41530) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bKSbP-0007Bi-20 for qemu-devel@nongnu.org; Tue, 05 Jul 2016 11:49:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bKSbO-000686-3x for qemu-devel@nongnu.org; Tue, 05 Jul 2016 11:49:35 -0400 Date: Tue, 5 Jul 2016 16:49:25 +0100 From: "Daniel P. Berrange" Message-ID: <20160705154925.GA6553@redhat.com> Reply-To: "Daniel P. Berrange" References: <1467732272-23368-1-git-send-email-clord@redhat.com> <1467732272-23368-5-git-send-email-clord@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1467732272-23368-5-git-send-email-clord@redhat.com> Subject: Re: [Qemu-devel] [PATCH v3 04/32] blockdev: Move bochs probe into separate file List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Colin Lord Cc: qemu-devel@nongnu.org, kwolf@redhat.com, qemu-block@nongnu.org, mreitz@redhat.com On Tue, Jul 05, 2016 at 11:24:04AM -0400, Colin Lord wrote: > This puts the bochs probe function into its own separate file as part of > the process of modularizing block drivers. Having the probe functions > separate from the rest of the driver allows us to probe without having > to potentially unnecessarily load the driver. > > Signed-off-by: Colin Lord > --- > block/Makefile.objs | 1 + > block/bochs.c | 55 ++------------------------------------------ > block/probe/bochs.c | 21 +++++++++++++++++ Do we really need a sub-dir for this ? If we were going to have sub-dirs under block/, I'd suggest we have one subdir per block driver, not spread code for one block driver across multiple dirs. IMHO a block/bochs-probe.c would be better, unless we did move block/bochs.c into a block/bochs/driver.c dir. Either way, you should update MAINTAINERS file to record this newly added filename, against the bochs entry. The same applies to most other patches in this series adding new files. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|