From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36853)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1bKgbp-0002yg-Tr
	for qemu-devel@nongnu.org; Wed, 06 Jul 2016 02:46:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1bKgbk-0000dZ-CE
	for qemu-devel@nongnu.org; Wed, 06 Jul 2016 02:46:56 -0400
Received: from mx1.redhat.com ([209.132.183.28]:59454)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1bKgbk-0000dV-6P
	for qemu-devel@nongnu.org; Wed, 06 Jul 2016 02:46:52 -0400
Date: Wed, 6 Jul 2016 14:46:50 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20160706064650.GB16605@ad.usersys.redhat.com>
References: <1467774199-21807-1-git-send-email-caoj.fnst@cn.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1467774199-21807-1-git-send-email-caoj.fnst@cn.fujitsu.com>
Subject: Re: [Qemu-devel] [PATCH] main-loop: check return value before using
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Cao jin <caoj.fnst@cn.fujitsu.com>
Cc: qemu-devel@nongnu.org, pbonzini@redhat.com

On Wed, 07/06 11:03, Cao jin wrote:
> pointer 'qemu_aio_context' should be checked first before it is used.
> qemu_bh_new() will use it.
> 
> Also add extra newlines to make code well separated and easier to read.

This "also" is not good, please only do one thing in a patch.

Fam

> 
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> ---
>  main-loop.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/main-loop.c b/main-loop.c
> index 89a6994..0d943f1 100644
> --- a/main-loop.c
> +++ b/main-loop.c
> @@ -154,18 +154,23 @@ int qemu_init_main_loop(Error **errp)
>      }
>  
>      qemu_aio_context = aio_context_new(&local_error);
> -    qemu_notify_bh = qemu_bh_new(notify_event_cb, NULL);
>      if (!qemu_aio_context) {
>          error_propagate(errp, local_error);
>          return -EMFILE;
>      }
> +
> +    qemu_notify_bh = qemu_bh_new(notify_event_cb, NULL);
> +
>      gpollfds = g_array_new(FALSE, FALSE, sizeof(GPollFD));
> +
>      src = aio_get_g_source(qemu_aio_context);
>      g_source_attach(src, NULL);
>      g_source_unref(src);
> +
>      src = iohandler_get_g_source();
>      g_source_attach(src, NULL);
>      g_source_unref(src);
> +
>      return 0;
>  }
>  
> -- 
> 2.1.0
> 
> 
> 
>