From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38438) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bKnl6-000527-Qq for qemu-devel@nongnu.org; Wed, 06 Jul 2016 10:25:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bKnl2-00019t-4F for qemu-devel@nongnu.org; Wed, 06 Jul 2016 10:24:59 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:33879 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bKnl1-00019j-Va for qemu-devel@nongnu.org; Wed, 06 Jul 2016 10:24:56 -0400 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u66ENpPl113975 for ; Wed, 6 Jul 2016 10:24:55 -0400 Received: from e23smtp06.au.ibm.com (e23smtp06.au.ibm.com [202.81.31.148]) by mx0b-001b2d01.pphosted.com with ESMTP id 240nc02h80-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Wed, 06 Jul 2016 10:24:55 -0400 Received: from localhost by e23smtp06.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 7 Jul 2016 00:24:52 +1000 Date: Wed, 6 Jul 2016 19:54:44 +0530 From: Bharata B Rao Reply-To: bharata@linux.vnet.ibm.com References: <1467795561-1007-1-git-send-email-bharata@linux.vnet.ibm.com> <1467795561-1007-6-git-send-email-bharata@linux.vnet.ibm.com> <20160706134554.0886d547@172-15-179-184.lightspeed.austtx.sbcglobal.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160706134554.0886d547@172-15-179-184.lightspeed.austtx.sbcglobal.net> Message-Id: <20160706142444.GH25522@in.ibm.com> Subject: Re: [Qemu-devel] [RFC PATCH v1 5/5] cpu, spapr: Use migration_id from pseries-2.7 onwards List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: qemu-devel@nongnu.org, nikunj@linux.vnet.ibm.com, groug@kaod.org, qemu-ppc@nongnu.org, pbonzini@redhat.com, david@gibson.dropbear.id.au On Wed, Jul 06, 2016 at 01:45:54PM +0200, Igor Mammedov wrote: > On Wed, 6 Jul 2016 14:29:21 +0530 > Bharata B Rao wrote: > > > Turn on use-migration-id property. Starting from pseries-2.7, prefer > > the use of migration_id (cpu_dt_id) over cpu_index for cpu vmstate > > registration and in XICS code. > > > > This allows migration to work when CPU cores are not necessarily > > unplugged in LIFO order. > > > > TODO: Property use-migration-id is by default turned on, check > > if this needs to turned off for older machine type versions of > > all archs. > > > > Signed-off-by: Bharata B Rao > > --- > > hw/ppc/spapr.c | 5 +++++ > > qom/cpu.c | 1 + > > 2 files changed, 6 insertions(+) > > > > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > > index 7f33a1b..be9af10 100644 > > --- a/hw/ppc/spapr.c > > +++ b/hw/ppc/spapr.c > > @@ -2501,6 +2501,11 @@ DEFINE_SPAPR_MACHINE(2_7, "2.7", true); > > .driver = TYPE_SPAPR_PCI_HOST_BRIDGE,\ > > .property = "ddw",\ > > .value = stringify(off),\ > > + }, \ > > + { \ > > + .driver = TYPE_CPU,\ > > + .property = "use-migration-id",\ > > + .value = stringify(off),\ > nit, > why not to use "off" directly, stringify looks odd here. Was just following the previous property "ddw" did, will check if stringify can be dropped. Regards, Bharata.