From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34801) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bKpue-00061O-42 for qemu-devel@nongnu.org; Wed, 06 Jul 2016 12:43:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bKpuZ-0006Tl-MG for qemu-devel@nongnu.org; Wed, 06 Jul 2016 12:42:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56019) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bKpuZ-0006Th-GP for qemu-devel@nongnu.org; Wed, 06 Jul 2016 12:42:55 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 62CAF80082 for ; Wed, 6 Jul 2016 16:42:54 +0000 (UTC) From: marcandre.lureau@redhat.com Date: Wed, 6 Jul 2016 18:42:46 +0200 Message-Id: <20160706164246.22116-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH] qemu-sockets: use qapi_free_SocketAddress in cleanup List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: pbonzini@redhat.com, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= From: Marc-Andr=C3=A9 Lureau Commit 74b6ce43e3 uses the wrong free API for a SocketAddress, that may leak some linked data. Signed-off-by: Marc-Andr=C3=A9 Lureau --- util/qemu-sockets.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c index fb83d48..777af49 100644 --- a/util/qemu-sockets.c +++ b/util/qemu-sockets.c @@ -1012,7 +1012,7 @@ void socket_listen_cleanup(int fd, Error **errp) } } =20 - g_free(addr); + qapi_free_SocketAddress(addr); } =20 int socket_dgram(SocketAddress *remote, SocketAddress *local, Error **er= rp) --=20 2.9.0