From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52290)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1bKxDm-0000sE-JC
	for qemu-devel@nongnu.org; Wed, 06 Jul 2016 20:31:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1bKxDi-0001SL-Bk
	for qemu-devel@nongnu.org; Wed, 06 Jul 2016 20:31:13 -0400
Received: from mx1.redhat.com ([209.132.183.28]:46970)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1bKxDi-0001SH-66
	for qemu-devel@nongnu.org; Wed, 06 Jul 2016 20:31:10 -0400
Date: Thu, 7 Jul 2016 08:31:07 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20160707003107.GA4208@ad.usersys.redhat.com>
References: <1467774199-21807-1-git-send-email-caoj.fnst@cn.fujitsu.com>
	<20160706064650.GB16605@ad.usersys.redhat.com>
	<577CB746.10300@cn.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <577CB746.10300@cn.fujitsu.com>
Subject: Re: [Qemu-devel] [PATCH] main-loop: check return value before using
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Cao jin <caoj.fnst@cn.fujitsu.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org

On Wed, 07/06 15:46, Cao jin wrote:
> 
> On 07/06/2016 02:46 PM, Fam Zheng wrote:
> > On Wed, 07/06 11:03, Cao jin wrote:
> > > pointer 'qemu_aio_context' should be checked first before it is used.
> > > qemu_bh_new() will use it.
> > > 
> > > Also add extra newlines to make code well separated and easier to read.
> > 
> > This "also" is not good, please only do one thing in a patch.
> > 
> > Fam
> > 
> 
> Thanks Fam.
> 
> See what I was told before when come to here:
> http://lists.nongnu.org/archive/html/qemu-trivial/2015-10/msg00116.html
> http://lists.nongnu.org/archive/html/qemu-trivial/2015-10/msg00123.html
> 
> So since then, I always prefer to squeeze stylistics patch into a productive
> one.

Yes, but in this patch I think the blank line changes are 1) more of personal
taste, 2) completely unrelated (neither lines nor semantics) to the functional
change.

Fam