From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44536) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bL1QR-0004PV-OC for qemu-devel@nongnu.org; Thu, 07 Jul 2016 01:00:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bL1QN-0002N4-NX for qemu-devel@nongnu.org; Thu, 07 Jul 2016 01:00:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52094) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bL1QN-0002Mz-9z for qemu-devel@nongnu.org; Thu, 07 Jul 2016 01:00:31 -0400 Date: Thu, 7 Jul 2016 13:00:28 +0800 From: Fam Zheng Message-ID: <20160707050028.GA12042@ad.usersys.redhat.com> References: <1467774199-21807-1-git-send-email-caoj.fnst@cn.fujitsu.com> <20160706064650.GB16605@ad.usersys.redhat.com> <577CB746.10300@cn.fujitsu.com> <20160707003107.GA4208@ad.usersys.redhat.com> <577DCA1C.2020809@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <577DCA1C.2020809@cn.fujitsu.com> Subject: Re: [Qemu-devel] [PATCH] main-loop: check return value before using List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cao jin Cc: pbonzini@redhat.com, qemu-devel@nongnu.org On Thu, 07/07 11:18, Cao jin wrote: > > > On 07/07/2016 08:31 AM, Fam Zheng wrote: > > On Wed, 07/06 15:46, Cao jin wrote: > > > > > > > Yes, but in this patch I think the blank line changes are 1) more of personal > > taste, 2) completely unrelated (neither lines nor semantics) to the functional > > change. > > > > Fam > > Indeed, my personal taste. Generally speaking, well separated code block is > easier for newbies to read. This is what I has been trained before, and I > like it, so I just can't help to add these lines when the code in my hand:P > BTW, I am curious about maintainer`s opinion about this thing:) It of course doesn't hurt git blame, as far as I can tell. Please Cc qemu-trivial in the separate patch. Fam