From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37533) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bL5cq-0002i2-LA for qemu-devel@nongnu.org; Thu, 07 Jul 2016 05:29:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bL5cm-0003dC-FY for qemu-devel@nongnu.org; Thu, 07 Jul 2016 05:29:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48293) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bL5cm-0003d8-9h for qemu-devel@nongnu.org; Thu, 07 Jul 2016 05:29:36 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9313D3B70D for ; Thu, 7 Jul 2016 09:29:34 +0000 (UTC) Date: Thu, 7 Jul 2016 10:29:31 +0100 From: "Daniel P. Berrange" Message-ID: <20160707092931.GH31666@redhat.com> Reply-To: "Daniel P. Berrange" References: <1467876887-2259-1-git-send-email-kraxel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1467876887-2259-1-git-send-email-kraxel@redhat.com> Subject: Re: [Qemu-devel] [RfC PATCH] gtk: prefer version 3.x List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org On Thu, Jul 07, 2016 at 09:34:47AM +0200, Gerd Hoffmann wrote: > This patch flips the default from gtk2 to gtk3. > > Sounds like a bigger change than it actually is as configure already > uses gtk3 in case it doesn't find gtk2. So this changes behavior > only in case both gtk2 and gtk3 devel packages are installed. As a point of note, GTK 3.0 was released in 2011, so its had 5 years to get into distros now, which is more than enough for QEMU to consider it a valid default choice over GTK 2.x > Signed-off-by: Gerd Hoffmann > --- > configure | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/configure b/configure > index e9090a0..e029eee 100755 > --- a/configure > +++ b/configure > @@ -2154,11 +2154,9 @@ fi > # GTK probe > > if test "$gtkabi" = ""; then > - # The GTK ABI was not specified explicitly, so try whether 2.0 is available. > - # Use 3.0 as a fallback if that is available. > - if $pkg_config --exists "gtk+-2.0 >= 2.18.0"; then > - gtkabi=2.0 > - elif $pkg_config --exists "gtk+-3.0 >= 3.0.0"; then > + # The GTK ABI was not specified explicitly, so try whether 3.0 is available. > + # Use 2.0 as a fallback. > + if $pkg_config --exists "gtk+-3.0 >= 3.0.0"; then > gtkabi=3.0 > else > gtkabi=2.0 Reviewed-by: Daniel P. Berrange I'd further suggest that you might want to explicitly say that GTK-2.0 support is deprecated, and set a date for its removal, as its days are clearly numbered, and it'd let us take advantage of more advanced GTK 3.0 features without piling on yet more #ifdefs. Perhaps print a warning in configure to say GTK-2.0 will be removed in the first release of 2018, if people use --with-gtkabi=2.0 Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|