From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46934) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bL8XJ-0003Bx-0N for qemu-devel@nongnu.org; Thu, 07 Jul 2016 08:36:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bL8XE-0002yO-1r for qemu-devel@nongnu.org; Thu, 07 Jul 2016 08:36:08 -0400 Received: from oxalide-out.extra.cea.fr ([132.168.224.8]:34420) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bL8XD-0002xQ-Mm for qemu-devel@nongnu.org; Thu, 07 Jul 2016 08:36:03 -0400 Received: from pisaure.intra.cea.fr (pisaure.intra.cea.fr [132.166.88.21]) by oxalide.extra.cea.fr (8.15.2/8.15.2/CEAnet-Internet-out-2.4) with ESMTP id u67CZu1h032620 for ; Thu, 7 Jul 2016 14:35:56 +0200 Received: from pisaure.intra.cea.fr (localhost [127.0.0.1]) by localhost (Postfix) with SMTP id 811FB204D2A for ; Thu, 7 Jul 2016 14:35:56 +0200 (CEST) Received: from muguet2.intra.cea.fr (muguet2.intra.cea.fr [132.166.192.7]) by pisaure.intra.cea.fr (Postfix) with ESMTP id 75BB2204835 for ; Thu, 7 Jul 2016 14:35:56 +0200 (CEST) Received: from zia.cdc.esteban.ctsi (out.dam.intra.cea.fr [132.165.76.10]) by muguet2.intra.cea.fr (8.15.2/8.15.2/CEAnet-Intranet-out-1.4) with SMTP id u67CZuq1000650 for ; Thu, 7 Jul 2016 14:35:56 +0200 Date: Thu, 7 Jul 2016 14:35:40 +0200 From: Dominique Martinet Message-ID: <20160707123540.GA15192@u-isr-cdi-08> References: <146659832556.15781.17414806975641516683.stgit@bahia.lan> <20160704141655.GA5799@u-isr-cdi-08> <20160704170849.1654d6a0@bahia.lan> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: <20160704170849.1654d6a0@bahia.lan> Subject: Re: [Qemu-devel] [PATCH 0/3] fs/9p: fix setattr/getattr issues with open files List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Greg Kurz Cc: Eric Van Hensbergen , Latchesar Ionkov , linux-kernel@vger.kernel.org, qemu-devel@nongnu.org, v9fs-developer@lists.sourceforge.net, Ron Minnich , "David S. Miller" Hi Greg, Greg Kurz wrote on Mon, Jul 04, 2016 at 05:08:49PM +0200: > On Mon, 4 Jul 2016 16:16:55 +0200 > Dominique Martinet wrote: > > > I *think* this introduces a race somewhere, I'm getting errors like: > > cat: f.05: No such file or directory > > cat: f.14: No such file or directory > > cat: f.13: No such file or directory > > cat: f.39: No such file or directory > > cat: f.05: No such file or directory > > > > > > when doing: > > for file in {01..50}; do touch f.${file}; done > > seq 1 1000 | xargs -n 1 -P 25 -I{} cat f.* > /dev/null Ok so, tested with the first two patches and I can't seem to hit any problem with the qemu server at least (I'd need more time to fix ganesha's 9p tcp/rdma server before I could blame the client in any way) The last patch looks good to me, I think it only makes an existing race more visible... What I think could happen is: process 1 has file open process 2 tries to open file, sees fid open process 1 closes file/clunk fids process 2 tries to clone now-clunked fid and gets ENOENT I'm afraid I just found out my hypervisor is no longer recent enough for gdb kernel scripts (gdb 7.6 and python 2.7.5 in el7 compared to the apparently required 7.7 and 2.7.6 respectively...), and I don't see anything obvious with just debug messages/adding a few printks (wasn't able to confirm where exactly that ENOENT comes from or if my theory is even close to the truth) I'd like to spend more time on it but don't think I'll be able to for a couple of weeks ; sorry about that. Were you able to reproduce the problem? Thanks, -- Dominique