From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47297) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLBu0-0004yM-JO for qemu-devel@nongnu.org; Thu, 07 Jul 2016 12:11:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bLBtu-0002HV-Ko for qemu-devel@nongnu.org; Thu, 07 Jul 2016 12:11:47 -0400 Received: from 1.mo69.mail-out.ovh.net ([178.33.251.173]:50274) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLBtu-0002HI-Dg for qemu-devel@nongnu.org; Thu, 07 Jul 2016 12:11:42 -0400 Received: from player779.ha.ovh.net (b9.ovh.net [213.186.33.59]) by mo69.mail-out.ovh.net (Postfix) with ESMTP id 9F8401010625 for ; Thu, 7 Jul 2016 18:11:41 +0200 (CEST) Date: Thu, 7 Jul 2016 18:11:31 +0200 From: Greg Kurz Message-ID: <20160707181131.3d9926fc@bahia.lan> In-Reply-To: <1467903025-13383-4-git-send-email-bharata@linux.vnet.ibm.com> References: <1467903025-13383-1-git-send-email-bharata@linux.vnet.ibm.com> <1467903025-13383-4-git-send-email-bharata@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH v2 3/5] spapr: Set stable_cpu_id for threads of CPU cores List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bharata B Rao Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org, david@gibson.dropbear.id.au, imammedo@redhat.com, nikunj@linux.vnet.ibm.com, pbonzini@redhat.com On Thu, 7 Jul 2016 20:20:23 +0530 Bharata B Rao wrote: > Conditonally set stable_cpu_id for CPU threads that are created as part > of spapr CPU cores. The use of stable_cpu_id is enabled for pseries-2.7 > onwards. > The last sentence is a bit confusing since the enablement actually happens in patch 5/5. > Signed-off-by: Bharata B Rao > --- > hw/ppc/spapr_cpu_core.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/hw/ppc/spapr_cpu_core.c b/hw/ppc/spapr_cpu_core.c > index b104778..0ec3513 100644 > --- a/hw/ppc/spapr_cpu_core.c > +++ b/hw/ppc/spapr_cpu_core.c > @@ -293,8 +293,15 @@ static void spapr_cpu_core_realize(DeviceState *dev, Error **errp) > for (i = 0; i < cc->nr_threads; i++) { > char id[32]; > obj = sc->threads + i * size; > + CPUState *cs; > > object_initialize(obj, size, typename); > + cs = CPU(obj); > + > + /* Use core_id (which is actually cpu_dt_id) as stable CPU id */ It isn't what I had in mind. More something like below: In ppc_spapr_init(): for (i = 0; i < spapr_max_cores; i++) { spapr->cores[i]->stable_id = i * smp_threads; } In spapr_cpu_core_realize(): for (j = 0; j < cc->nr_threads; j++) { stable_cpu_id = cc->stable_id + j; } So we need to introduce cc->stable_id. I think stable_cpu_id is the prerequisite to compute both cpu_dt_id and instance_id. Makes sense ? > + if (cs->has_stable_cpu_id) { > + cs->stable_cpu_id = cc->core_id + i; > + } > snprintf(id, sizeof(id), "thread[%d]", i); > object_property_add_child(OBJECT(sc), id, obj, &local_err); > if (local_err) {