From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47532) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLMaV-0001pw-1W for qemu-devel@nongnu.org; Thu, 07 Jul 2016 23:36:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bLMaS-0005R4-NM for qemu-devel@nongnu.org; Thu, 07 Jul 2016 23:36:22 -0400 Received: from ozlabs.org ([2401:3900:2:1::2]:60933) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLMaS-0005Qp-A5 for qemu-devel@nongnu.org; Thu, 07 Jul 2016 23:36:20 -0400 Date: Fri, 8 Jul 2016 13:38:06 +1000 From: David Gibson Message-ID: <20160708033806.GA14675@voom.fritz.box> References: <1467934423-5997-1-git-send-email-andrew.smirnov@gmail.com> <1467934423-5997-5-git-send-email-andrew.smirnov@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="SLk8PSyqxe/ugcCT" Content-Disposition: inline In-Reply-To: <1467934423-5997-5-git-send-email-andrew.smirnov@gmail.com> Subject: Re: [Qemu-devel] [PATCH 4/9] address_space_write_continue: Distill common code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andrey Smirnov Cc: qemu-devel@nongnu.org --SLk8PSyqxe/ugcCT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 07, 2016 at 04:33:38PM -0700, Andrey Smirnov wrote: > Move call to memory_region_dispatch_write() outside of swtich statement > since the only thing that is different about all of those call is > "length" argument and that matches value in "l". Also collapse switch > statement to occupy less vertical space. >=20 > Signed-off-by: Andrey Smirnov I'm not a big fan of putting multiple statements on a single line, especially flow control like break. But apart from that, Reviewed-by: David Gibson > --- > exec.c | 31 +++++++------------------------ > 1 file changed, 7 insertions(+), 24 deletions(-) >=20 > diff --git a/exec.c b/exec.c > index c26bcea..eea3018 100644 > --- a/exec.c > +++ b/exec.c > @@ -2566,33 +2566,16 @@ static MemTxResult address_space_write_continue(A= ddressSpace *as, hwaddr addr, > /* XXX: could force current_cpu to NULL to avoid > potential bugs */ > switch (l) { > - case 8: > - /* 64 bit write access */ > - val =3D ldq_p(buf); > - result |=3D memory_region_dispatch_write(mr, addr1, val,= 8, > - attrs); > - break; > - case 4: > - /* 32 bit write access */ > - val =3D ldl_p(buf); > - result |=3D memory_region_dispatch_write(mr, addr1, val,= 4, > - attrs); > - break; > - case 2: > - /* 16 bit write access */ > - val =3D lduw_p(buf); > - result |=3D memory_region_dispatch_write(mr, addr1, val,= 2, > - attrs); > - break; > - case 1: > - /* 8 bit write access */ > - val =3D ldub_p(buf); > - result |=3D memory_region_dispatch_write(mr, addr1, val,= 1, > - attrs); > - break; > + case 8: val =3D ldq_p(buf); break; /* 64 bit write access */ > + case 4: val =3D ldl_p(buf); break; /* 32 bit write access */ > + case 2: val =3D lduw_p(buf); break; /* 16 bit write access */ > + case 1: val =3D ldub_p(buf); break; /* 8 bit write access */ > default: > abort(); > } > + > + result |=3D memory_region_dispatch_write(mr, addr1, val, l, > + attrs); > } else { > /* RAM case */ > ptr =3D qemu_map_ram_ptr(mr->ram_block, addr1); --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --SLk8PSyqxe/ugcCT Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXfyAeAAoJEGw4ysog2bOS/58QANOssi72D3hU6vu0cSZb0AbY 4tpc9HzWoh1fAUUKpsseZ6DU8ZQgddeR5+sfGUQ7zXpi4O3pH0vgDM0e1afmQqHq NYL5CFNFQdbX85jKX8XsocIQ2fIKz7vlNm4oLLNTKtm+NF1sypgPHjdYoaxu2Sww DptHp+RQgIBjeO1LYQC/Af41t8yOf3XrPfm1O7bb22uuw012zssx+RldGCw/SM5T Pe7webd3PWiUUhSDsTbPLIukDa55KY+U+32jcqqv1jC1xbfJHAaJatZKxIrulxF/ QBQuwDcuSFp/pIS21Q+jE7hQNlPaG67pM0OcGMhpFV7c2XAJv8Lb1rTxjvPZp4fs SjF5ObHL3vhiC4Nno03+3EYIfH94pxiDEPiMoJFR0A77hGsE5efY+7j//mccuJB0 5O8/FB/vvqo+Tljn5geeHPSS/TeHJF9Y0mDuZ/AEKJ4ZA0Gk+T9pl60kAL70wmb8 oJ8wEtSQ4h12sJwupAT8nBqjBW9wHmGy8LOW3iJF5VLy445GaL9tuluf6QlieMqX RFQDJ9GbqoXPQ+KrWm8xFM2hHAFsWLifZPjGVQRBRLVNS27q9BaOC+zF2R4qdoH6 9fxJS2uLUPIZpPYhjvjWcx5L1Hr2wgvb4HKLPYnBFDY/dq14+Hd3OCPwNLXoR3K+ BTS0fmR+2vAivO9n1zeU =ks+z -----END PGP SIGNATURE----- --SLk8PSyqxe/ugcCT--