From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48534) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLMjq-0003Ei-HO for qemu-devel@nongnu.org; Thu, 07 Jul 2016 23:46:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bLMjp-0006s8-Bt for qemu-devel@nongnu.org; Thu, 07 Jul 2016 23:46:02 -0400 Received: from ozlabs.org ([2401:3900:2:1::2]:58791) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLMjp-0006rw-0G for qemu-devel@nongnu.org; Thu, 07 Jul 2016 23:46:01 -0400 Date: Fri, 8 Jul 2016 13:46:35 +1000 From: David Gibson Message-ID: <20160708034635.GE14675@voom.fritz.box> References: <1467934423-5997-1-git-send-email-andrew.smirnov@gmail.com> <1467934423-5997-9-git-send-email-andrew.smirnov@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="gqO6s7S91gFL8ZIQ" Content-Disposition: inline In-Reply-To: <1467934423-5997-9-git-send-email-andrew.smirnov@gmail.com> Subject: Re: [Qemu-devel] [PATCH 8/9] gdbstub: Convert target_memory_rw_debug to use MMUAccessType List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andrey Smirnov Cc: qemu-devel@nongnu.org --gqO6s7S91gFL8ZIQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 07, 2016 at 04:33:42PM -0700, Andrey Smirnov wrote: > Convert target_memory_rw_debug to use MMUAccessType as to follow similar > conversion of cpu_memory_rw_debug. Apart from previously mentioned concerns with the confusingly named MMU_* tokens, Reviewed-by: David Gibson >=20 > Signed-off-by: Andrey Smirnov > --- > gdbstub.c | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) >=20 > diff --git a/gdbstub.c b/gdbstub.c > index 89cb538..a8cff45 100644 > --- a/gdbstub.c > +++ b/gdbstub.c > @@ -44,15 +44,16 @@ > #endif > =20 > static inline int target_memory_rw_debug(CPUState *cpu, target_ulong add= r, > - uint8_t *buf, int len, bool is_= write) > + uint8_t *buf, int len, > + MMUAccessType access_type) > { > CPUClass *cc =3D CPU_GET_CLASS(cpu); > =20 > if (cc->memory_rw_debug) { > + const bool is_write =3D (access_type =3D=3D MMU_DATA_STORE); > return cc->memory_rw_debug(cpu, addr, buf, len, is_write); > } > - return cpu_memory_rw_debug(cpu, addr, buf, len, > - is_write ? MMU_DATA_STORE : MMU_DATA_LOAD= ); > + return cpu_memory_rw_debug(cpu, addr, buf, len, access_type); > } > =20 > enum { > @@ -966,7 +967,8 @@ static int gdb_handle_packet(GDBState *s, const char = *line_buf) > break; > } > =20 > - if (target_memory_rw_debug(s->g_cpu, addr, mem_buf, len, false) = !=3D 0) { > + if (target_memory_rw_debug(s->g_cpu, addr, mem_buf, > + len, MMU_DATA_LOAD) !=3D 0) { > put_packet (s, "E14"); > } else { > memtohex(buf, mem_buf, len); > @@ -988,7 +990,7 @@ static int gdb_handle_packet(GDBState *s, const char = *line_buf) > } > hextomem(mem_buf, p, len); > if (target_memory_rw_debug(s->g_cpu, addr, mem_buf, len, > - true) !=3D 0) { > + MMU_DATA_STORE) !=3D 0) { > put_packet(s, "E14"); > } else { > put_packet(s, "OK"); --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --gqO6s7S91gFL8ZIQ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXfyIbAAoJEGw4ysog2bOS1aEP/jBaItu+YqXh5R3pN/1UbLXm gz6OEjNb4dNay5jjIdLDydq5i27vDe7ioMRdJr9HIEMtU1tyjpa0Qj2mrax7Eken rANqmu4OvBqfNR5r17u9si6PXGdp9d3IrTA7RoJeS1FUlc0xLk11Lmp1VxxXa43w TSS+TLwf0sAeE5nUzLL0QuxUWg2QnMAAIIT+mq5Xv1uB6eM0MLtOM5Gl3F05zyzZ Xg9+c23tcB5B/b8ZphYgxCop+JG0O+iTo0zJRz5gnOcQIHJCF1ky29TTg6zuubZX Xte2/mI88Yot9HK1PXSXfVnILXt0KfKB+jXICWRyUKH1FnxX6FCPlNx2olz1pKW4 bshAyiKuRTrBMadyp6jpvblnTNXU1deYWS9xh4HZJ6tdBOAO9n5Xmxi19NnUXr+T eXv6LMFIVUBiY/+eYEP6tl6syBasenwrauw4bLYmDfxkzM2fPWkLeAIwNfHJkxdB X4ddVQ/Wdh3ApgSoslRGmT3+D+iXJanNtw03sFrGD5oXjvnk6myanhTbC+KH5xVE y4ikKMnlNXzva75Lhzw2XY9VeD+i5BVKmeUhw7hlqjt55Js9F6EwkIlf8rA9Oxt1 ONGsoIVaeQOeda+MINRC6wVFpeeDfOKbBdgVTcXg2gM67/oB7IBalLsy7HBlqQYX LNefkUzyT/05fR5GjVnu =RwVB -----END PGP SIGNATURE----- --gqO6s7S91gFL8ZIQ--