From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48451) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLS7w-00035y-JL for qemu-devel@nongnu.org; Fri, 08 Jul 2016 05:31:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bLS7v-0001TD-Nr for qemu-devel@nongnu.org; Fri, 08 Jul 2016 05:31:16 -0400 Date: Fri, 8 Jul 2016 11:31:06 +0200 From: Kevin Wolf Message-ID: <20160708093106.GD14684@noname.redhat.com> References: <1467732272-23368-1-git-send-email-clord@redhat.com> <1467732272-23368-5-git-send-email-clord@redhat.com> <20160705154925.GA6553@redhat.com> <32a142e7-8e46-9ae7-30b0-df42876601cb@redhat.com> <20160706082428.GD5233@noname.str.redhat.com> <998cb3c6-46c9-e60c-d807-102911912384@redhat.com> <7e27ce0f-5e3a-3e2f-5601-9014c040b793@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7e27ce0f-5e3a-3e2f-5601-9014c040b793@redhat.com> Subject: Re: [Qemu-devel] [PATCH v3 04/32] blockdev: Move bochs probe into separate file List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: John Snow , "Daniel P. Berrange" , qemu-block@nongnu.org, qemu-devel@nongnu.org, Markus Armbruster , mreitz@redhat.com Am 07.07.2016 um 18:01 hat Paolo Bonzini geschrieben: > On 06/07/2016 18:09, John Snow wrote: > > Recently the include files in hw/ide/ were moved to include/ without > > anybody mentioning it to me, including internal.h. > > > > Why? > > Because hw/ide/internal.h is not so internal. In particular, it is > included by hw/ide/pci.h, which is included by hw/i386/pc_q35.c. Probably it should be split in a truly internal part that remains in hw/ide/ and part for the public interface. Kevin