From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58456) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLYft-0002pg-Lj for qemu-devel@nongnu.org; Fri, 08 Jul 2016 12:30:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bLYfr-0007kA-Fv for qemu-devel@nongnu.org; Fri, 08 Jul 2016 12:30:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36204) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLYfr-0007k5-A3 for qemu-devel@nongnu.org; Fri, 08 Jul 2016 12:30:43 -0400 Date: Fri, 8 Jul 2016 10:30:41 -0600 From: Alex Williamson Message-ID: <20160708103041.40862960@t450s.home> In-Reply-To: <1467965903-22766-4-git-send-email-davidkiarie4@gmail.com> References: <1467965903-22766-1-git-send-email-davidkiarie4@gmail.com> <1467965903-22766-4-git-send-email-davidkiarie4@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [V13 3/4] hw/i386: Introduce AMD IOMMU List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Kiarie Cc: qemu-devel@nongnu.org, marcel@redhat.com, mst@redhat.com, peterx@redhat.com, valentine.sinitsyn@gmail.com, jan.kiszka@web.de, ehabkost@redhat.com On Fri, 8 Jul 2016 11:18:22 +0300 David Kiarie wrote: > Add AMD IOMMU emulaton to Qemu in addition to Intel IOMMU. > The IOMMU does basic translation, error checking and has a > minimal IOTLB implementation. This IOMMU bypassed the need > for target aborts by responding with IOMMU_NONE access rights > and exempts the region 0xfee00000-0xfeefffff from translation > as it is the q35 interrupt region. > > We advertise features that are not yet implemented to please > the Linux IOMMU driver. > > IOTLB aims at implementing commands on real IOMMUs which is > essential for debugging and may not offer any performance > benefits > > Signed-off-by: David Kiarie > --- > hw/i386/Makefile.objs | 1 + > hw/i386/amd_iommu.c | 1384 +++++++++++++++++++++++++++++++++++++++++++++++++ > hw/i386/amd_iommu.h | 285 ++++++++++ > 3 files changed, 1670 insertions(+) > create mode 100644 hw/i386/amd_iommu.c > create mode 100644 hw/i386/amd_iommu.h Hi, Please consider an update or follow-on patch which adds something similar to: commit 3cb3b1549f5401dc3a5e1d073e34063dc274136f Author: Alex Williamson Date: Thu Jun 30 13:00:24 2016 -0600 intel_iommu: Throw hw_error on notify_started http://git.qemu.org/?p=qemu.git;a=commit;h=3cb3b1549f5401dc3a5e1d073e34063dc274136f This would simply make amd_iommu incompatible with device assignment until someone tackles adding the proper code to support it. Thanks, Alex