From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35250) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLTS8-0005eq-Pv for qemu-devel@nongnu.org; Fri, 08 Jul 2016 06:56:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bLTS6-0001bv-VF for qemu-devel@nongnu.org; Fri, 08 Jul 2016 06:56:11 -0400 Date: Fri, 8 Jul 2016 12:56:00 +0200 From: Kevin Wolf Message-ID: <20160708105600.GJ14684@noname.redhat.com> References: <1466465969-25315-1-git-send-email-eblake@redhat.com> <1466465969-25315-2-git-send-email-eblake@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1466465969-25315-2-git-send-email-eblake@redhat.com> Subject: Re: [Qemu-devel] [PATCH 1/5] block: Fragment reads to max transfer length List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, Stefan Hajnoczi , Fam Zheng , Max Reitz Am 21.06.2016 um 01:39 hat Eric Blake geschrieben: > Drivers should be able to rely on the block layer honoring the > max transfer length, rather than needing to return -EINVAL > (iscsi) or manually fragment things (nbd). This patch adds > the fragmentation in the block layer, after requests have been > aligned (fragmenting before alignment would lead to multiple > unaligned requests, rather than just the head and tail). > > Signed-off-by: Eric Blake Doesn't build for me: block/io.c: In function 'bdrv_aligned_preadv': block/io.c:1071:5: error: 'ret' may be used uninitialized in this function [-Werror=maybe-uninitialized] return ret; Kevin