From: Kevin Wolf <kwolf@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
Paolo Bonzini <pbonzini@redhat.com>,
Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 5/5] nbd: Drop unused offset parameter
Date: Fri, 8 Jul 2016 13:11:16 +0200 [thread overview]
Message-ID: <20160708111116.GL14684@noname.redhat.com> (raw)
In-Reply-To: <1466465969-25315-6-git-send-email-eblake@redhat.com>
Am 21.06.2016 um 01:39 hat Eric Blake geschrieben:
> Now that NBD relies on the block layer to fragment things, we no
> longer need to track an offset argument for which fragment of
> a request we are actually servicing.
>
> While at it, use true and false instead of 0 and 1 for a bool
> parameter.
>
> Signed-off-by: Eric Blake <eblake@redhat.com>
> @@ -35,7 +34,7 @@ ssize_t nbd_wr_syncv(QIOChannel *ioc,
>
> nlocal_iov = iov_copy(local_iov, nlocal_iov,
> iov, niov,
> - offset, length);
> + 0, length);
This statement fits in a single line instead of three.
Kevin
next prev parent reply other threads:[~2016-07-08 11:11 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-20 23:39 [Qemu-devel] [PATCH 0/5] Auto-fragment large transactions at the block layer Eric Blake
2016-06-20 23:39 ` [Qemu-devel] [PATCH 1/5] block: Fragment reads to max transfer length Eric Blake
2016-07-08 10:56 ` Kevin Wolf
2016-07-08 14:31 ` Eric Blake
2016-06-20 23:39 ` [Qemu-devel] [PATCH 2/5] block: Fragment writes " Eric Blake
2016-06-20 23:39 ` [Qemu-devel] [PATCH 3/5] raw_bsd: Don't advertise flags not supported by protocol layer Eric Blake
2016-07-08 11:05 ` Kevin Wolf
2016-07-08 14:32 ` Eric Blake
2016-06-20 23:39 ` [Qemu-devel] [PATCH 4/5] nbd: Rely on block layer to break up large requests Eric Blake
2016-06-20 23:39 ` [Qemu-devel] [PATCH 5/5] nbd: Drop unused offset parameter Eric Blake
2016-07-08 11:11 ` Kevin Wolf [this message]
2016-06-21 3:19 ` [Qemu-devel] [PATCH 6/5] iscsi: Rely on block layer to break up large requests Eric Blake
2016-06-21 4:17 ` [Qemu-devel] [PATCH 0/5] Auto-fragment large transactions at the block layer Eric Blake
2016-06-21 10:23 ` Stefan Hajnoczi
2016-06-21 10:43 ` Kevin Wolf
2016-06-22 11:41 ` Stefan Hajnoczi
2016-06-21 22:05 ` Eric Blake
2016-06-22 11:41 ` Stefan Hajnoczi
2016-06-22 5:54 ` Fam Zheng
2016-07-06 2:04 ` Eric Blake
2016-07-08 11:15 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160708111116.GL14684@noname.redhat.com \
--to=kwolf@redhat.com \
--cc=eblake@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).