qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: Fam Zheng <famz@redhat.com>,
	qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/5] Auto-fragment large transactions at the block layer
Date: Fri, 8 Jul 2016 13:15:15 +0200	[thread overview]
Message-ID: <20160708111515.GM14684@noname.redhat.com> (raw)
In-Reply-To: <577C6741.4060804@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1266 bytes --]

Am 06.07.2016 um 04:04 hat Eric Blake geschrieben:
> On 06/21/2016 11:54 PM, Fam Zheng wrote:
> > On Mon, 06/20 17:39, Eric Blake wrote:
> >> We have max_transfer documented in BlockLimits, but while we
> >> honor it during pwrite_zeroes, we were blindly ignoring it
> >> during pwritev and preadv, leading to multiple drivers having
> >> to implement fragmentation themselves.  This series moves
> >> fragmentation to the block layer, then fixes the NBD driver to
> >> use it; if you like this but it needs a v2, you can request that
> >> I further do other drivers (I know at least iscsi and qcow2 do
> >> some self-fragmenting and/or error reporting that can be
> >> simplified by deferring fragmentation to the block layer).
> >>
> >> Prequisite: Kevin's block branch, plus my work on byte-based
> >> block limits (v2 at the moment):
> >> https://lists.gnu.org/archive/html/qemu-devel/2016-06/msg04006.html
> >>
> >> Also available as a tag at:
> >> git fetch git://repo.or.cz/qemu/ericb.git nbd-fragment-v1
> > 
> > Patches 1-6:
> > 
> > Reviewed-by: Fam Zheng <famz@redhat.com>
> 
> ping - series still applies to latest master without tweaks

Apart from the build fix and the minor comments I made, this looks good
to me.

Kevin

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

      reply	other threads:[~2016-07-08 11:15 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-20 23:39 [Qemu-devel] [PATCH 0/5] Auto-fragment large transactions at the block layer Eric Blake
2016-06-20 23:39 ` [Qemu-devel] [PATCH 1/5] block: Fragment reads to max transfer length Eric Blake
2016-07-08 10:56   ` Kevin Wolf
2016-07-08 14:31     ` Eric Blake
2016-06-20 23:39 ` [Qemu-devel] [PATCH 2/5] block: Fragment writes " Eric Blake
2016-06-20 23:39 ` [Qemu-devel] [PATCH 3/5] raw_bsd: Don't advertise flags not supported by protocol layer Eric Blake
2016-07-08 11:05   ` Kevin Wolf
2016-07-08 14:32     ` Eric Blake
2016-06-20 23:39 ` [Qemu-devel] [PATCH 4/5] nbd: Rely on block layer to break up large requests Eric Blake
2016-06-20 23:39 ` [Qemu-devel] [PATCH 5/5] nbd: Drop unused offset parameter Eric Blake
2016-07-08 11:11   ` Kevin Wolf
2016-06-21  3:19 ` [Qemu-devel] [PATCH 6/5] iscsi: Rely on block layer to break up large requests Eric Blake
2016-06-21  4:17 ` [Qemu-devel] [PATCH 0/5] Auto-fragment large transactions at the block layer Eric Blake
2016-06-21 10:23 ` Stefan Hajnoczi
2016-06-21 10:43   ` Kevin Wolf
2016-06-22 11:41     ` Stefan Hajnoczi
2016-06-21 22:05   ` Eric Blake
2016-06-22 11:41     ` Stefan Hajnoczi
2016-06-22  5:54 ` Fam Zheng
2016-07-06  2:04   ` Eric Blake
2016-07-08 11:15     ` Kevin Wolf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160708111515.GM14684@noname.redhat.com \
    --to=kwolf@redhat.com \
    --cc=eblake@redhat.com \
    --cc=famz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).