From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37102) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMQrS-0006tc-Tr for qemu-devel@nongnu.org; Sun, 10 Jul 2016 22:22:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bMQrO-0002mr-JG for qemu-devel@nongnu.org; Sun, 10 Jul 2016 22:22:18 -0400 Received: from ozlabs.org ([103.22.144.67]:44588) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMQrO-0002mn-7t for qemu-devel@nongnu.org; Sun, 10 Jul 2016 22:22:14 -0400 Date: Mon, 11 Jul 2016 12:24:01 +1000 From: David Gibson Message-ID: <20160711022401.GI16355@voom.fritz.box> References: <1467934423-5997-1-git-send-email-andrew.smirnov@gmail.com> <1467934423-5997-7-git-send-email-andrew.smirnov@gmail.com> <20160708034259.GC14675@voom.fritz.box> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="wZdghQXYJzyo6AGC" Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH 6/9] Convert cpu_memory_rw_debug to use MMUAccessType List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Andrey Smirnov , QEMU Developers --wZdghQXYJzyo6AGC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jul 10, 2016 at 08:32:32PM +0100, Peter Maydell wrote: > On 8 July 2016 at 04:42, David Gibson wrote: > > My only concern here is that the constants are named > > *MMU*_DATA_... whereas these are physical memory accesses not > > involving the MMU. I can't actually see any current users of > > MMUAccessType which makes me a bit confused as to what it's intended > > meaning was >=20 > If you grep for MMU_DATA_LOAD/MMU_DATA_STORE/MMU_INST_FETCH > you'll see the uses. A lot of the softmmu code uses the > convention of 0=3Dread,1=3Dwrite,2=3Dinsn (which developed I > think historically from a bool "is_write", which you'll > still see in some function argument names, that was > augmented to handle insn-fetch separately). The enum > gives us some symbolic names for the constant values. > (There's a proposed patch somewhere to change the > 'int is_write' arguments to actually use the enum type.) Ah, yes, I see. Still surprisingly few, actually. My concern about the potentially misleading name still stands.. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --wZdghQXYJzyo6AGC Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXgwNAAAoJEGw4ysog2bOSKNcP/1fZg21EqebSVWnsKZFuHJST GqxIRcE6oI8I17AOE5OxFD8MCD6fgTNm6f68Xp1umSoycVzgeh41t/HE/ESxwlpl j0urH2y1HoRvWmX20IuPzx/ZoV/e/kwUy42reu90q6wbWYAXuUgpbI1SQK4dap5F Q0qEQIRt/Wulo2cAY9bVRC8xozp/lcGIlCBpChwV9q+IlRobbaH5Eoo0jeE9PfAj 0BB1Z1arhRFYQEs210a+fcBanXZQBTGvFbIVRBd/e7qZUELEe644nH/lx4XU5auY KuruJ6Qc+8jHqptwGJTPlH8fFqossphjdIbrkxjiHG1LWc/jWhQttlSqXDPWQBO3 /DTgoMhx+pAWWY+L6hDIgaEgsCYXxpG4d1onR9BfBmwaVdZxIvzpUFWvuAOb4715 2uDwH6SzlPvKZE+G69tv4bZTMIlYfrHiRx1Ms2RvIEXi/ZV75J1lvXPJ2IMcrMoh HiCXGQlogpy3xdN19Wb6Dq5A+9gJTT7sTOaohZSIQUyCrV/Vmu68phXmXBkLrq5z rz0E+ub9qYtN/+M+UHqLYtS7nH6oiSbkOi0AvfoEAIjkSawbdQdQi/R3jhfrtRRe Bfpb/ArRiUDj0SRo975oUMbxnvA1fQ2JO4N9BdYvXSrYDivU5Bjc5Pxy6vuIqfwW w0fVEJMQomGRleBKcaml =BQ+v -----END PGP SIGNATURE----- --wZdghQXYJzyo6AGC--