From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50626) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMV1o-00063F-W2 for qemu-devel@nongnu.org; Mon, 11 Jul 2016 02:49:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bMV1l-0003lS-QD for qemu-devel@nongnu.org; Mon, 11 Jul 2016 02:49:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44804) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMV1l-0003lB-K5 for qemu-devel@nongnu.org; Mon, 11 Jul 2016 02:49:13 -0400 Date: Mon, 11 Jul 2016 14:49:04 +0800 From: Peter Xu Message-ID: <20160711064904.GC3204@pxdev.xzpeter.org> References: <1467706769-12505-1-git-send-email-peterx@redhat.com> <1467706769-12505-5-git-send-email-peterx@redhat.com> <5780B278.7020001@web.de> <20160711053219.GB3204@pxdev.xzpeter.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v11 04/28] x86-iommu: q35: generalize find_add_as() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Kiarie Cc: Jan Kiszka , QEMU Developers , imammedo@redhat.com, rth@twiddle.net, Eduardo Habkost , jasowang@redhat.com, Marcel Apfelbaum , "Michael S. Tsirkin" , pbonzini@redhat.com, rkrcmar@redhat.com, alex.williamson@redhat.com, wexu@redhat.com On Mon, Jul 11, 2016 at 08:46:12AM +0300, David Kiarie wrote: > On Mon, Jul 11, 2016 at 8:32 AM, Peter Xu wrote: > > On Sat, Jul 09, 2016 at 10:14:48AM +0200, Jan Kiszka wrote: > >> On 2016-07-05 10:19, Peter Xu wrote: > >> > Remove VT-d calls in common q35 codes. Instead, we provide a general > >> > find_add_as() for x86-iommu type. > >> > > >> > Signed-off-by: Peter Xu > >> > --- > >> > hw/i386/intel_iommu.c | 15 ++++++++------- > >> > include/hw/i386/intel_iommu.h | 5 ----- > >> > include/hw/i386/x86-iommu.h | 3 +++ > >> > 3 files changed, 11 insertions(+), 12 deletions(-) > >> > >> You claim to remove something from "common q35 code", but I don't see > >> changes to it. Instead, the patch introduces a method that seems to > >> remain unused outside the implementing class (I just grep'ed your tree). > >> Anything missing? > > > > Right. The commit message lost its point after I did the rebase to > > Marcel's "-device intel_iommu" patches... Thanks for pointing it out. > > I think Jan is mainly asking about where the method 'find_add_as()' is > being used. Unless I'm too missing something It doesn't seem to be > used anywhere outside the implementing class. This patch can be dropped. I was just not sure whether it's the correct time to do that. Anyway, we may still need one more patch to cleanup this in the future, as I have mentioned in the previous email. I see that mst is possibly not around these two days. Let me prepare a v12 before he comes back. Thank you. -- peterx