From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: peter.maydell@linaro.org
Cc: borntraeger@de.ibm.com, agraf@suse.de, jfrei@linux.vnet.ibm.com,
qemu-devel@nongnu.org, Sascha Silbe <silbe@linux.vnet.ibm.com>,
Cornelia Huck <cornelia.huck@de.ibm.com>
Subject: [Qemu-devel] [PULL 06/25] s390x/css: use define for "virtual-css-bridge" literal
Date: Mon, 11 Jul 2016 10:08:53 +0200 [thread overview]
Message-ID: <20160711080912.13947-7-cornelia.huck@de.ibm.com> (raw)
In-Reply-To: <20160711080912.13947-1-cornelia.huck@de.ibm.com>
From: Sascha Silbe <silbe@linux.vnet.ibm.com>
Introduce a TYPE_* define (like we already use for a couple of other
QOM types) for the name of the virtual CSS bridge QOM type instead of
sprinkling the same string literal over several source files.
Signed-off-by: Sascha Silbe <silbe@linux.vnet.ibm.com>
Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
---
hw/s390x/s390-virtio-ccw.c | 2 +-
hw/s390x/virtio-ccw.c | 4 ++--
hw/s390x/virtio-ccw.h | 3 +++
3 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c
index 52f079a..3b79e96 100644
--- a/hw/s390x/s390-virtio-ccw.c
+++ b/hw/s390x/s390-virtio-ccw.c
@@ -29,7 +29,7 @@
#include "hw/s390x/s390-virtio-ccw.h"
static const char *const reset_dev_types[] = {
- "virtual-css-bridge",
+ TYPE_VIRTUAL_CSS_BRIDGE,
"s390-sclp-event-facility",
"s390-flic",
"diag288",
diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c
index 67d7867..0afc0d3 100644
--- a/hw/s390x/virtio-ccw.c
+++ b/hw/s390x/virtio-ccw.c
@@ -130,7 +130,7 @@ VirtualCssBus *virtual_css_bus_init(void)
DeviceState *dev;
/* Create bridge device */
- dev = qdev_create(NULL, "virtual-css-bridge");
+ dev = qdev_create(NULL, TYPE_VIRTUAL_CSS_BRIDGE);
qdev_init_nofail(dev);
/* Create bus on bridge device */
@@ -1626,7 +1626,7 @@ static void virtual_css_bridge_class_init(ObjectClass *klass, void *data)
}
static const TypeInfo virtual_css_bridge_info = {
- .name = "virtual-css-bridge",
+ .name = TYPE_VIRTUAL_CSS_BRIDGE,
.parent = TYPE_SYS_BUS_DEVICE,
.instance_size = sizeof(SysBusDevice),
.class_init = virtual_css_bridge_class_init,
diff --git a/hw/s390x/virtio-ccw.h b/hw/s390x/virtio-ccw.h
index 7243fb0..6144625 100644
--- a/hw/s390x/virtio-ccw.h
+++ b/hw/s390x/virtio-ccw.h
@@ -101,6 +101,9 @@ static inline int virtio_ccw_rev_max(VirtioCcwDevice *dev)
return dev->max_rev;
}
+/* virtual css bridge type */
+#define TYPE_VIRTUAL_CSS_BRIDGE "virtual-css-bridge"
+
/* virtual css bus type */
typedef struct VirtualCssBus {
BusState parent_obj;
--
2.9.0
next prev parent reply other threads:[~2016-07-11 8:09 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-11 8:08 [Qemu-devel] [PULL 00/25] s390x patches for 2.7 Cornelia Huck
2016-07-11 8:08 ` [Qemu-devel] [PULL 01/25] pc-bios/s390-ccw: Pass selected SCSI device to IPL Cornelia Huck
2016-07-11 8:08 ` [Qemu-devel] [PULL 02/25] pc-bios/s390-ccw.img: rebuild image Cornelia Huck
2016-07-11 8:08 ` [Qemu-devel] [PULL 03/25] s390x/ipl: Support IPL from selected SCSI device Cornelia Huck
2016-07-11 8:08 ` [Qemu-devel] [PULL 04/25] s390x/ipl: fix reboots for migration from different bios Cornelia Huck
2016-07-11 8:08 ` [Qemu-devel] [PULL 05/25] s390x/css: factor out some generic code from virtio_ccw_device_realize() Cornelia Huck
2016-07-11 8:08 ` Cornelia Huck [this message]
2016-07-11 8:08 ` [Qemu-devel] [PULL 07/25] s390x/css: Factor out virtual css bridge and bus Cornelia Huck
2016-07-11 8:08 ` [Qemu-devel] [PULL 08/25] s390x/css: Unplug handler of virtual css bridge Cornelia Huck
2016-07-11 8:08 ` [Qemu-devel] [PULL 09/25] s390x/pci: fix failures of dma map/unmap Cornelia Huck
2016-07-11 8:08 ` [Qemu-devel] [PULL 10/25] s390x/pci: acceleration for getting S390pciState Cornelia Huck
2016-07-11 8:08 ` [Qemu-devel] [PULL 11/25] s390x/pci: write fid in CLP_QUERY_PCI_FN Cornelia Huck
2016-07-11 8:08 ` [Qemu-devel] [PULL 12/25] s390x/pci: unify FH_ macros Cornelia Huck
2016-07-11 8:09 ` [Qemu-devel] [PULL 13/25] s390x/pci: refactor s390_pci_find_dev_by_fh Cornelia Huck
2016-07-11 8:09 ` [Qemu-devel] [PULL 14/25] s390x/pci: enforce zPCI state checking Cornelia Huck
2016-07-11 8:09 ` [Qemu-devel] [PULL 15/25] s390x/pci: introduce S390PCIBus Cornelia Huck
2016-07-11 8:09 ` [Qemu-devel] [PULL 16/25] s390x/pci: introduce S390PCIIOMMU Cornelia Huck
2016-07-11 8:09 ` [Qemu-devel] [PULL 17/25] s390x/pci: introduce S390PCIBusDevice qdev Cornelia Huck
2016-07-11 8:09 ` [Qemu-devel] [PULL 18/25] s390x/pci: enable uid-checking Cornelia Huck
2016-07-11 8:09 ` [Qemu-devel] [PULL 19/25] s390x/pci: enable zpci hot-plug/hot-unplug Cornelia Huck
2016-07-11 8:09 ` [Qemu-devel] [PULL 20/25] s390x/pci: add checkings in CLP_SET_PCI_FN Cornelia Huck
2016-07-11 8:09 ` [Qemu-devel] [PULL 21/25] s390x/pci: refactor s390_pci_find_dev_by_idx Cornelia Huck
2016-07-11 8:09 ` [Qemu-devel] [PULL 22/25] s390x/pci: refactor list_pci Cornelia Huck
2016-07-11 8:09 ` [Qemu-devel] [PULL 23/25] s390x/pci: fix stpcifc_service_call Cornelia Huck
2016-07-11 8:09 ` [Qemu-devel] [PULL 24/25] s390x/pci: replace fid with idx in msg data of msix Cornelia Huck
2016-07-11 8:09 ` [Qemu-devel] [PULL 25/25] s390x/pci: make hot-unplug handler smoother Cornelia Huck
2016-07-12 8:48 ` [Qemu-devel] [PULL 00/25] s390x patches for 2.7 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160711080912.13947-7-cornelia.huck@de.ibm.com \
--to=cornelia.huck@de.ibm.com \
--cc=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=jfrei@linux.vnet.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=silbe@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).