From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54401) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMbxG-0006GJ-Ht for qemu-devel@nongnu.org; Mon, 11 Jul 2016 10:13:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bMbxB-00011J-0b for qemu-devel@nongnu.org; Mon, 11 Jul 2016 10:13:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39973) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMbxA-00011F-R6 for qemu-devel@nongnu.org; Mon, 11 Jul 2016 10:12:56 -0400 Date: Mon, 11 Jul 2016 16:12:52 +0200 From: Igor Mammedov Message-ID: <20160711161252.631eb17a@nial.brq.redhat.com> In-Reply-To: <1468244718-3731-1-git-send-email-guangrong.xiao@linux.intel.com> References: <1468244718-3731-1-git-send-email-guangrong.xiao@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/8] nvdimm: hotplug support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Xiao Guangrong Cc: pbonzini@redhat.com, ehabkost@redhat.com, kvm@vger.kernel.org, mst@redhat.com, gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, dan.j.williams@intel.com, rth@twiddle.net On Mon, 11 Jul 2016 21:45:10 +0800 Xiao Guangrong wrote: > This patchset is against commit 269fe4c3ab0c (vmw_pvscsi: remove unnecessary > internal msi state flag) on pci branch of Michael's git tree and can be found > at: > https://github.com/xiaogr/qemu.git nvdimm-hotplug-v1 > > This patchset enables nvdimm hotplug support, it is used as pc-dimm hotplug, > for example, a new nvdimm device can be plugged as follows: > object_add memory-backend-file,id=mem3,size=10G,mem-path=/home/eric/nvdimm3 > device_add nvdimm,id=nvdimm3,memdev=mem3 > > and unplug it as follows: > device_del nvdimm3 > object_del mem3 Could you fix crash in hmp related to nvdimm? https://bugzilla.redhat.com/show_bug.cgi?id=1352769 I've checked and it reproduces on upstream as well. > > Xiao Guangrong (8): > acpi nvdimm: fix wrong buffer size returned by DSM method > nvdimm acpi: prebuild nvdimm devices for available slots > nvdimm acpi: introduce _FIT > nvdimm acpi: implement Read FIT function > pc-dimm: introduce prepare_unplug() callback > pc: memhp: do not export nvdimm's memory via _CRS > pc: acpi: memhp: nvdimm hotplug support > nvdimm docs: add nvdimm Read FIT function > > docs/specs/acpi_mem_hotplug.txt | 4 +- > docs/specs/acpi_nvdimm.txt | 38 +++++++- > hw/acpi/ich9.c | 3 + > hw/acpi/memory_hotplug.c | 21 +++-- > hw/acpi/nvdimm.c | 195 +++++++++++++++++++++++++++++++++++---- > hw/acpi/piix4.c | 3 + > hw/i386/acpi-build.c | 28 +++++- > hw/mem/nvdimm.c | 12 ++- > hw/mem/pc-dimm.c | 5 + > include/hw/acpi/memory_hotplug.h | 1 + > include/hw/acpi/pc-hotplug.h | 1 + > include/hw/mem/nvdimm.h | 6 +- > include/hw/mem/pc-dimm.h | 1 + > 13 files changed, 278 insertions(+), 40 deletions(-) >