From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52282) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMto9-0006xp-Cl for qemu-devel@nongnu.org; Tue, 12 Jul 2016 05:16:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bMto5-0005dT-64 for qemu-devel@nongnu.org; Tue, 12 Jul 2016 05:16:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42572) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMto5-0005dK-0S for qemu-devel@nongnu.org; Tue, 12 Jul 2016 05:16:45 -0400 Date: Tue, 12 Jul 2016 17:16:42 +0800 From: Fam Zheng Message-ID: <20160712091642.GB14150@ad.usersys.redhat.com> References: <1468300800-31256-1-git-send-email-famz@redhat.com> <1468300800-31256-2-git-send-email-famz@redhat.com> <20160712110903.4cca688d.cornelia.huck@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160712110903.4cca688d.cornelia.huck@de.ibm.com> Subject: Re: [Qemu-devel] [PATCH 1/6] virtio-bus: Drop "set_handler" parameter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck Cc: qemu-devel@nongnu.org, kwolf@redhat.com, pbonzini@redhat.com, stefanha@redhat.com, mst@redhat.com On Tue, 07/12 11:09, Cornelia Huck wrote: > On Tue, 12 Jul 2016 13:19:55 +0800 > Fam Zheng wrote: > > > It always equals to assign now. > > I think this needs further elaboration... > > > > > Signed-off-by: Fam Zheng > > Reviewed-by: Stefan Hajnoczi > > --- > > hw/virtio/virtio-bus.c | 13 ++++++------- > > 1 file changed, 6 insertions(+), 7 deletions(-) > > > > > @@ -167,7 +166,7 @@ static int set_host_notifier_internal(DeviceState *proxy, VirtioBusState *bus, > > error_report("%s: unable to init event notifier: %d", __func__, r); > > return r; > > } > > - virtio_queue_set_host_notifier_fd_handler(vq, true, set_handler); > > + virtio_queue_set_host_notifier_fd_handler(vq, true, true); > > r = k->ioeventfd_assign(proxy, notifier, n, assign); > > if (r < 0) { > > error_report("%s: unable to assign ioeventfd: %d", __func__, r); > > > @@ -269,7 +268,7 @@ int virtio_bus_set_host_notifier(VirtioBusState *bus, int n, bool assign) > > */ > > virtio_bus_stop_ioeventfd(bus); > > } > > - return set_host_notifier_internal(proxy, bus, n, assign, false); > > + return set_host_notifier_internal(proxy, bus, n, assign); > > ...because this changes the behaviour for assign==true. Oh this is the one I overlook in rebase because it wasn't present with your refactoring but it is now back in commit 0830c96d70b. Good catch, I need to fix this, and therefore Stefan's r-b shouldn't have been kept along. Fam > > > } > > > > static char *virtio_bus_get_dev_path(DeviceState *dev) >