From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org, kwolf@redhat.com, pbonzini@redhat.com,
stefanha@redhat.com, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/6] virtio-bus: Drop "set_handler" parameter
Date: Tue, 12 Jul 2016 11:21:05 +0200 [thread overview]
Message-ID: <20160712112105.7d8144ab.cornelia.huck@de.ibm.com> (raw)
In-Reply-To: <20160712091642.GB14150@ad.usersys.redhat.com>
On Tue, 12 Jul 2016 17:16:42 +0800
Fam Zheng <famz@redhat.com> wrote:
> On Tue, 07/12 11:09, Cornelia Huck wrote:
> > On Tue, 12 Jul 2016 13:19:55 +0800
> > > @@ -269,7 +268,7 @@ int virtio_bus_set_host_notifier(VirtioBusState *bus, int n, bool assign)
> > > */
> > > virtio_bus_stop_ioeventfd(bus);
> > > }
> > > - return set_host_notifier_internal(proxy, bus, n, assign, false);
> > > + return set_host_notifier_internal(proxy, bus, n, assign);
> >
> > ...because this changes the behaviour for assign==true.
>
> Oh this is the one I overlook in rebase because it wasn't present with your
> refactoring but it is now back in commit 0830c96d70b.
Yes, we need to come up with a proper solution, but I currently don't
see this for 2.7.
>
> Good catch, I need to fix this, and therefore Stefan's r-b shouldn't have been
> kept along.
The whole host notifier stuff is good at causing headaches :(
next prev parent reply other threads:[~2016-07-12 9:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-12 5:19 [Qemu-devel] [PATCH 0/6] virtio: Merge virtio-{blk, scsi} host notifier handling paths Fam Zheng
2016-07-12 5:19 ` [Qemu-devel] [PATCH 1/6] virtio-bus: Drop "set_handler" parameter Fam Zheng
2016-07-12 9:09 ` Cornelia Huck
2016-07-12 9:16 ` Fam Zheng
2016-07-12 9:21 ` Cornelia Huck [this message]
2016-07-12 5:19 ` [Qemu-devel] [PATCH 2/6] virtio: Add typedef for handle_output Fam Zheng
2016-07-12 5:19 ` [Qemu-devel] [PATCH 3/6] virtio: Introduce virtio_add_queue_aio Fam Zheng
2016-07-12 5:19 ` [Qemu-devel] [PATCH 4/6] virtio-blk: Call virtio_add_queue_aio Fam Zheng
2016-07-12 5:19 ` [Qemu-devel] [PATCH 5/6] virtio-scsi: " Fam Zheng
2016-07-12 5:20 ` [Qemu-devel] [PATCH 6/6] Revert "mirror: Workaround for unexpected iohandler events during completion" Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160712112105.7d8144ab.cornelia.huck@de.ibm.com \
--to=cornelia.huck@de.ibm.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).