From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39722)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1bMwqU-0007uG-7r
	for qemu-devel@nongnu.org; Tue, 12 Jul 2016 08:31:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1bMwqN-0000rP-Kt
	for qemu-devel@nongnu.org; Tue, 12 Jul 2016 08:31:25 -0400
Received: from mx1.redhat.com ([209.132.183.28]:58301)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1bMwqN-0000rD-Ep
	for qemu-devel@nongnu.org; Tue, 12 Jul 2016 08:31:19 -0400
Date: Tue, 12 Jul 2016 14:31:14 +0200
From: Igor Mammedov <imammedo@redhat.com>
Message-ID: <20160712143114.65e7b089@nial.brq.redhat.com>
In-Reply-To: <20160712025442.GG19132@thinpad.lan.raisama.net>
References: <1467786055-85835-1-git-send-email-imammedo@redhat.com>
	<1467786055-85835-9-git-send-email-imammedo@redhat.com>
	<20160712025442.GG19132@thinpad.lan.raisama.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 08/19] pc: implement
 query-hotpluggable-cpus callback
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org, pkrempa@redhat.com, mst@redhat.com, armbru@redhat.com, eduardo.otubo@profitbricks.com, marcel@redhat.com, pbonzini@redhat.com, rth@twiddle.net

On Mon, 11 Jul 2016 23:54:42 -0300
Eduardo Habkost <ehabkost@redhat.com> wrote:

> On Wed, Jul 06, 2016 at 08:20:44AM +0200, Igor Mammedov wrote:
> > it returns a list of present/possible to hotplug CPU
> > objects with a list of properties to use with
> > device_add.
> > 
> > in PC case returned list would looks like:  
> > -> { "execute": "query-hotpluggable-cpus" }  
> > <- {"return": [
> >      {
> >         "type": "qemu64-x86_64-cpu", "vcpus-count": 1,
> >         "props": {"core-id": 0, "socket-id": 1, "thread-id": 0}
> >      },
> >      {
> >         "qom-path": "/machine/unattached/device[0]",
> >         "type": "qemu64-x86_64-cpu", "vcpus-count": 1,
> >         "props": {"core-id": 0, "socket-id": 0, "thread-id": 0}
> >      }
> >    ]}
> > 
> > Signed-off-by: Igor Mammedov <imammedo@redhat.com>  
> 
> Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
> 
> But shouldn't this be at the end of the series, or at least after
> the code that makes device_add work with X86CPU?
sure, I'll move it there