From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58412) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMxxs-0008Kz-8m for qemu-devel@nongnu.org; Tue, 12 Jul 2016 09:43:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bMxxn-0007jV-Ba for qemu-devel@nongnu.org; Tue, 12 Jul 2016 09:43:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39588) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMxxn-0007jP-5m for qemu-devel@nongnu.org; Tue, 12 Jul 2016 09:43:03 -0400 Date: Tue, 12 Jul 2016 15:42:58 +0200 From: Igor Mammedov Message-ID: <20160712154258.3f5f1bba@nial.brq.redhat.com> In-Reply-To: <20160712144843.6a87d1a1@nial.brq.redhat.com> References: <1467786055-85835-1-git-send-email-imammedo@redhat.com> <1467786055-85835-10-git-send-email-imammedo@redhat.com> <20160712032908.GH19132@thinpad.lan.raisama.net> <20160712144843.6a87d1a1@nial.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 09/19] pc: delay setting number of boot CPUs to machine_done time List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: pkrempa@redhat.com, mst@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, eduardo.otubo@profitbricks.com, marcel@redhat.com, pbonzini@redhat.com, rth@twiddle.net On Tue, 12 Jul 2016 14:48:43 +0200 Igor Mammedov wrote: > On Tue, 12 Jul 2016 00:29:08 -0300 > Eduardo Habkost wrote: [...] > > 1) x86_cpu_realizefn(): > > if (cpu->env.features[FEAT_1_EDX] & CPUID_APIC || smp_cpus > 1) { > > x86_cpu_apic_create(cpu, &local_err); Usage of smp_cpus here looks incorrect to me, it should be max_cpus. But we can't make it max_cpus without compat glue as it will break backwards migration (not that upstream cares about it)