From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55630)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cornelia.huck@de.ibm.com>) id 1bNG4b-0003kZ-2g
	for qemu-devel@nongnu.org; Wed, 13 Jul 2016 05:03:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <cornelia.huck@de.ibm.com>) id 1bNG4W-0002Va-TC
	for qemu-devel@nongnu.org; Wed, 13 Jul 2016 05:03:16 -0400
Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:38579)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <cornelia.huck@de.ibm.com>) id 1bNG4W-0002VO-JE
	for qemu-devel@nongnu.org; Wed, 13 Jul 2016 05:03:12 -0400
Received: from pps.filterd (m0098396.ppops.net [127.0.0.1])
	by mx0a-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id
	u6D8ro85117153
	for <qemu-devel@nongnu.org>; Wed, 13 Jul 2016 05:03:12 -0400
Received: from e06smtp13.uk.ibm.com (e06smtp13.uk.ibm.com [195.75.94.109])
	by mx0a-001b2d01.pphosted.com with ESMTP id 2448qmsf99-1
	(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)
	for <qemu-devel@nongnu.org>; Wed, 13 Jul 2016 05:03:11 -0400
Received: from localhost
	by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <cornelia.huck@de.ibm.com>;
	Wed, 13 Jul 2016 10:03:09 +0100
Received: from b06cxnps4075.portsmouth.uk.ibm.com
	(d06relay12.portsmouth.uk.ibm.com [9.149.109.197])
	by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 2DA7A17D8024
	for <qemu-devel@nongnu.org>; Wed, 13 Jul 2016 10:04:33 +0100 (BST)
Received: from d06av05.portsmouth.uk.ibm.com (d06av05.portsmouth.uk.ibm.com
	[9.149.37.229])
	by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with
	ESMTP id u6D936Tv40567008
	for <qemu-devel@nongnu.org>; Wed, 13 Jul 2016 09:03:06 GMT
Received: from d06av05.portsmouth.uk.ibm.com (localhost [127.0.0.1])
	by d06av05.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with
	ESMTP id u6D936Kf001586
	for <qemu-devel@nongnu.org>; Wed, 13 Jul 2016 03:03:06 -0600
Date: Wed, 13 Jul 2016 11:03:05 +0200
From: Cornelia Huck <cornelia.huck@de.ibm.com>
In-Reply-To: <1468386588-26584-2-git-send-email-famz@redhat.com>
References: <1468386588-26584-1-git-send-email-famz@redhat.com>
	<1468386588-26584-2-git-send-email-famz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Message-Id: <20160713110305.1a09bf8e.cornelia.huck@de.ibm.com>
Subject: Re: [Qemu-devel] [PATCH v4 1/6] virtio: Add typedef for
 handle_output
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org, kwolf@redhat.com, pbonzini@redhat.com, stefanha@redhat.com, mst@redhat.com

On Wed, 13 Jul 2016 13:09:43 +0800
Fam Zheng <famz@redhat.com> wrote:

> The function pointer signature has been repeated a few times, using a
> typedef may make coding easier.
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>  hw/virtio/virtio.c         | 9 ++++-----
>  include/hw/virtio/virtio.h | 5 +++--
>  2 files changed, 7 insertions(+), 7 deletions(-)

Maybe merge patch 6?

Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>