From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56471) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNGAf-00015c-Ce for qemu-devel@nongnu.org; Wed, 13 Jul 2016 05:09:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bNGAZ-0003dO-HW for qemu-devel@nongnu.org; Wed, 13 Jul 2016 05:09:32 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:47035 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNGAZ-0003dI-CT for qemu-devel@nongnu.org; Wed, 13 Jul 2016 05:09:27 -0400 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u6D93oi7007714 for ; Wed, 13 Jul 2016 05:09:27 -0400 Received: from e06smtp06.uk.ibm.com (e06smtp06.uk.ibm.com [195.75.94.102]) by mx0b-001b2d01.pphosted.com with ESMTP id 245jp986cp-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Wed, 13 Jul 2016 05:09:26 -0400 Received: from localhost by e06smtp06.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 13 Jul 2016 10:09:25 +0100 Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 60ACB219006C for ; Wed, 13 Jul 2016 10:08:50 +0100 (BST) Received: from d06av10.portsmouth.uk.ibm.com (d06av10.portsmouth.uk.ibm.com [9.149.37.251]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u6D99L5f18088418 for ; Wed, 13 Jul 2016 09:09:21 GMT Received: from d06av10.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av10.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u6D89OAx000394 for ; Wed, 13 Jul 2016 02:09:24 -0600 Date: Wed, 13 Jul 2016 11:09:20 +0200 From: Cornelia Huck In-Reply-To: <1468386588-26584-4-git-send-email-famz@redhat.com> References: <1468386588-26584-1-git-send-email-famz@redhat.com> <1468386588-26584-4-git-send-email-famz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-Id: <20160713110920.6cb8f2cc.cornelia.huck@de.ibm.com> Subject: Re: [Qemu-devel] [PATCH v4 3/6] virtio-blk: Call virtio_add_queue_aio List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: qemu-devel@nongnu.org, kwolf@redhat.com, pbonzini@redhat.com, stefanha@redhat.com, mst@redhat.com On Wed, 13 Jul 2016 13:09:45 +0800 Fam Zheng wrote: > AIO based handler is more appropriate here because it will then > cooperate with bdrv_drained_begin/end. It is needed by the coming > revert patch. Not sure whether you really need to refer to an upcoming patch: I think it is enough for the revert patch to refer to this and the virtio-scsi patch. (I'm always a bit confused if I see things like this in the log later on.) > > Signed-off-by: Fam Zheng > --- > hw/block/virtio-blk.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c > index ae86e94..97578a4 100644 > --- a/hw/block/virtio-blk.c > +++ b/hw/block/virtio-blk.c > @@ -913,7 +913,7 @@ static void virtio_blk_device_realize(DeviceState *dev, Error **errp) > s->sector_mask = (s->conf.conf.logical_block_size / BDRV_SECTOR_SIZE) - 1; > > for (i = 0; i < conf->num_queues; i++) { > - virtio_add_queue(vdev, 128, virtio_blk_handle_output); > + virtio_add_queue_aio(vdev, 128, virtio_blk_handle_output); > } > virtio_blk_data_plane_create(vdev, conf, &s->dataplane, &err); > if (err != NULL) { Reviewed-by: Cornelia Huck