From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56964)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1bNLej-0003Am-T1
	for qemu-devel@nongnu.org; Wed, 13 Jul 2016 11:01:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1bNLee-0002E9-Lz
	for qemu-devel@nongnu.org; Wed, 13 Jul 2016 11:00:56 -0400
Received: from mx1.redhat.com ([209.132.183.28]:33822)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1bNLee-0002E4-GQ
	for qemu-devel@nongnu.org; Wed, 13 Jul 2016 11:00:52 -0400
Date: Wed, 13 Jul 2016 17:00:48 +0200
From: Igor Mammedov <imammedo@redhat.com>
Message-ID: <20160713170048.23fcab26@nial.brq.redhat.com>
In-Reply-To: <20160712024827.GF19132@thinpad.lan.raisama.net>
References: <1467786055-85835-1-git-send-email-imammedo@redhat.com>
	<1467786055-85835-8-git-send-email-imammedo@redhat.com>
	<20160712024827.GF19132@thinpad.lan.raisama.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 07/19] pc: set APIC ID based on
 socket/core/thread ids if it's not been set yet
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: pkrempa@redhat.com, mst@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, eduardo.otubo@profitbricks.com, marcel@redhat.com, pbonzini@redhat.com, rth@twiddle.net

On Mon, 11 Jul 2016 23:48:27 -0300
Eduardo Habkost <ehabkost@redhat.com> wrote:

> On Wed, Jul 06, 2016 at 08:20:43AM +0200, Igor Mammedov wrote:
> > CPU added with device_add help won't have APIC ID set,
> > so set it according to socket/core/thread ids provided
> > with device_add command.
> > 
> > Signed-off-by: Igor Mammedov <imammedo@redhat.com>
[...]
> 
> 
> > +                  " APIC ID (%" PRIu32 "), valid index range 0:%d",  
> 
> I thought you were going to change it to print APIC ID as hex.
Since unsigned variant for APIC ID is already in x86-next,
lets continue with that,
and I'll do a patch on top of series that changes printed APIC ID
to hex consistently all over the three.