From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43497)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1bNMSY-0004hF-Vz
	for qemu-devel@nongnu.org; Wed, 13 Jul 2016 11:52:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1bNMSU-00068P-PN
	for qemu-devel@nongnu.org; Wed, 13 Jul 2016 11:52:25 -0400
Received: from mx1.redhat.com ([209.132.183.28]:41035)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1bNMSU-00068J-J0
	for qemu-devel@nongnu.org; Wed, 13 Jul 2016 11:52:22 -0400
Date: Wed, 13 Jul 2016 17:52:18 +0200
From: Igor Mammedov <imammedo@redhat.com>
Message-ID: <20160713175218.4652949e@nial.brq.redhat.com>
In-Reply-To: <20160713145929.GJ3727@thinpad.lan.raisama.net>
References: <1467786055-85835-1-git-send-email-imammedo@redhat.com>
	<1467786055-85835-19-git-send-email-imammedo@redhat.com>
	<20160713145929.GJ3727@thinpad.lan.raisama.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 18/19] target-i386: add
 x86_cpu_unrealizefn()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: pkrempa@redhat.com, mst@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, eduardo.otubo@profitbricks.com, marcel@redhat.com, pbonzini@redhat.com, rth@twiddle.net

On Wed, 13 Jul 2016 11:59:29 -0300
Eduardo Habkost <ehabkost@redhat.com> wrote:

> On Wed, Jul 06, 2016 at 08:20:54AM +0200, Igor Mammedov wrote:
> > first remove VCPU from exec loop and only then remove lapic.
> > 
> > Signed-off-by: Chen Fan <chen.fan.fnst@cn.fujitsu.com>
> > Signed-off-by: Gu Zheng <guz.fnst@cn.fujitsu.com>
> > Signed-off-by: Zhu Guihua <zhugh.fnst@cn.fujitsu.com>
> > Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> > ---
> >  target-i386/cpu.c | 15 +++++++++++++++
> >  1 file changed, 15 insertions(+)
> > 
> > diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> > index 2fa445d..f86dae0 100644
> > --- a/target-i386/cpu.c
> > +++ b/target-i386/cpu.c
> > @@ -2963,6 +2963,20 @@ out:
> >      }
> >  }
> >  
> > +static void x86_cpu_unrealizefn(DeviceState *dev, Error **errp)
> > +{
> > +    X86CPU *cpu = X86_CPU(dev);
> > +
> > +#ifndef CONFIG_USER_ONLY
> > +    cpu_remove_sync(CPU(dev));
> > +    qemu_unregister_reset(x86_cpu_machine_reset_cb, dev);
> > +#endif
> > +
> > +    if (cpu->apic_state) {
> > +        object_unparent(OBJECT(cpu->apic_state));  
> 
> As patch 17/19 drops the reference corresponding to
> cpu->apic_state (leaving only the child property reference), this
> will leave cpu->apic_state pointing to a dead object. Please set
> it to NULL.
true, if we go with this explicit unparenting then
cpu->apic_state should be set to NULL.

If we only unrealize here then we do not need set cpu->apic_state to NULL
here as apic will die together with CPU instance when it starts to destroy
its children.

> 
> > +    }
> > +}
> > +
> >  typedef struct BitProperty {
> >      uint32_t *ptr;
> >      uint32_t mask;
> > @@ -3205,6 +3219,7 @@ static void x86_cpu_common_class_init(ObjectClass *oc, void *data)
> >  
> >      xcc->parent_realize = dc->realize;
> >      dc->realize = x86_cpu_realizefn;
> > +    dc->unrealize = x86_cpu_unrealizefn;
> >      dc->props = x86_cpu_properties;
> >  
> >      xcc->parent_reset = cc->reset;
> > -- 
> > 2.7.0
> >   
>