Re: [Qemu-devel] [PATCH RFC 04/16] hw/core/machine: Introduce pre_init

[Andrew Jones <drjones@redhat.com>]

On Thu, Jul 14, 2016 at 05:10:47PM -0300, Eduardo Habkost wrote:
> On Tue, Jun 14, 2016 at 07:58:56AM +0200, Andrew Jones wrote:
> > On Tue, Jun 14, 2016 at 11:30:37AM +1000, David Gibson wrote:
> > > On Fri, Jun 10, 2016 at 07:40:15PM +0200, Andrew Jones wrote:
> > > > From: Igor Mammedov <imammedo@redhat.com>
> > > > 
> > > > Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> > > > Signed-off-by: Andrew Jones <drjones@redhat.com>
> > > 
> > > I think this needs some kind of rationale.
> > > 
> > > Since with this patch it is called immediately before ->init, I'm not
> > > really seeing the point of this.
> > 
> > Many machines already override ->init, so if we want to move code
> > from vl.c into machine methods, but be sure that they run it now,
> > then we have to invent a pre-init. I (or Igor) can add something
> > like that to the commit message for the next round.
> 
> If we just want to move vl.c code into machine, why not just
> create a simple machine_pre_init() function?
> 
> We can add a virtual method that can be reimplemented by
> subclasses later, only when we really see the need for a subclass
> to override some behavior.

That's fine for this series. Of course one of the main motivators
of this series is to be able to override the old parsing though, so
I already see the need. I'll need to either add this method now, or
later, when I add cpu topo support to the ARM mach-virt machine type.

Thanks,
drew

> 
> -- 
> Eduardo
>