From: Sergey Fedorov <sergey.fedorov@linaro.org>
To: qemu-devel@nongnu.org
Cc: patches@linaro.org, "Sergey Fedorov" <serge.fdrv@gmail.com>,
mttcg@listserver.greensocs.com, fred.konrad@greensocs.com,
a.rigo@virtualopensystems.com, cota@braap.org,
bobby.prani@gmail.com, rth@twiddle.net,
mark.burton@greensocs.com, pbonzini@redhat.com,
jan.kiszka@siemens.com, peter.maydell@linaro.org,
claudio.fontana@huawei.com,
"Alex Bennée" <alex.bennee@linaro.org>,
"Sergey Fedorov" <sergey.fedorov@linaro.org>,
"Peter Crosthwaite" <crosthwaite.peter@gmail.com>
Subject: [Qemu-devel] [PATCH v4 08/12] tcg: set up tb->page_addr before insertion
Date: Fri, 15 Jul 2016 20:58:48 +0300 [thread overview]
Message-ID: <20160715175852.30749-9-sergey.fedorov@linaro.org> (raw)
In-Reply-To: <20160715175852.30749-1-sergey.fedorov@linaro.org>
From: Alex Bennée <alex.bennee@linaro.org>
This ensures that if we find the TB on the slow path that tb->page_addr
is correctly set before being tested.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Sergey Fedorov <sergey.fedorov@linaro.org>
Signed-off-by: Sergey Fedorov <sergey.fedorov@linaro.org>
---
translate-all.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/translate-all.c b/translate-all.c
index 9db72e8982b1..6156bdcbef42 100644
--- a/translate-all.c
+++ b/translate-all.c
@@ -1118,10 +1118,6 @@ static void tb_link_page(TranslationBlock *tb, tb_page_addr_t phys_pc,
{
uint32_t h;
- /* add in the hash table */
- h = tb_hash_func(phys_pc, tb->pc, tb->flags);
- qht_insert(&tcg_ctx.tb_ctx.htable, tb, h);
-
/* add in the page list */
tb_alloc_page(tb, 0, phys_pc & TARGET_PAGE_MASK);
if (phys_page2 != -1) {
@@ -1130,6 +1126,10 @@ static void tb_link_page(TranslationBlock *tb, tb_page_addr_t phys_pc,
tb->page_addr[1] = -1;
}
+ /* add in the hash table */
+ h = tb_hash_func(phys_pc, tb->pc, tb->flags);
+ qht_insert(&tcg_ctx.tb_ctx.htable, tb, h);
+
#ifdef DEBUG_TB_CHECK
tb_page_check();
#endif
--
2.9.1
next prev parent reply other threads:[~2016-07-15 17:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 17:58 [Qemu-devel] [PATCH v4 00/12] Reduce lock contention on TCG hot-path Sergey Fedorov
2016-07-15 17:58 ` [Qemu-devel] [PATCH v4 01/12] util/qht: Document memory ordering assumptions Sergey Fedorov
2016-07-15 17:58 ` [Qemu-devel] [PATCH v4 02/12] tcg: Pass last_tb by value to tb_find_fast() Sergey Fedorov
2016-07-15 17:58 ` [Qemu-devel] [PATCH v4 03/12] tcg: Prepare safe tb_jmp_cache lookup out of tb_lock Sergey Fedorov
2016-07-15 17:58 ` [Qemu-devel] [PATCH v4 04/12] tcg: Prepare safe access to tb_flushed " Sergey Fedorov
2016-07-15 17:58 ` [Qemu-devel] [PATCH v4 05/12] target-i386: Remove redundant HF_SOFTMMU_MASK Sergey Fedorov
2016-07-15 17:58 ` [Qemu-devel] [PATCH v4 06/12] tcg: Introduce tb_mark_invalid() and tb_is_invalid() Sergey Fedorov
2016-07-15 17:58 ` [Qemu-devel] [PATCH v4 07/12] tcg: Prepare TB invalidation for lockless TB lookup Sergey Fedorov
2016-07-15 17:58 ` Sergey Fedorov [this message]
2016-07-15 17:58 ` [Qemu-devel] [PATCH v4 09/12] tcg: cpu-exec: remove tb_lock from the hot-path Sergey Fedorov
2016-07-15 17:58 ` [Qemu-devel] [PATCH v4 10/12] tcg: Avoid bouncing tb_lock between tb_gen_code() and tb_add_jump() Sergey Fedorov
2016-07-15 17:58 ` [Qemu-devel] [PATCH v4 11/12] tcg: Merge tb_find_slow() and tb_find_fast() Sergey Fedorov
2016-07-15 17:58 ` [Qemu-devel] [PATCH v4 12/12] tcg: rename tb_find_physical() Sergey Fedorov
2016-07-16 13:51 ` [Qemu-devel] [PATCH v4 00/12] Reduce lock contention on TCG hot-path Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160715175852.30749-9-sergey.fedorov@linaro.org \
--to=sergey.fedorov@linaro.org \
--cc=a.rigo@virtualopensystems.com \
--cc=alex.bennee@linaro.org \
--cc=bobby.prani@gmail.com \
--cc=claudio.fontana@huawei.com \
--cc=cota@braap.org \
--cc=crosthwaite.peter@gmail.com \
--cc=fred.konrad@greensocs.com \
--cc=jan.kiszka@siemens.com \
--cc=mark.burton@greensocs.com \
--cc=mttcg@listserver.greensocs.com \
--cc=patches@linaro.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=serge.fdrv@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).